commit 04e63f26ba5f661fe28503e9aeb99fbdc5ea9a7b
author Tom Tromey <tom@tromey.com> Wed Apr 24 16:05:25 2024 -0600
committer Tom Tromey <tom@tromey.com> Fri May 10 12:41:13 2024 -0600
tree d6e9a673fc699251fc6b430808b15811e77ef054
parent a2f972b330b1575f49ea7a02103085378e7937c7

Remove tui_refresh_all

This removes tui_refresh_all.  There is only a single caller,
tui_refresh_all_win, so inlining the code there simplifies gdb at no
cost.

Reviewed-By: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
Approved-By: Andrew Burgess <aburgess@redhat.com>

gdb/tui/tui-win.c

diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c
index 8f4c7ec..85b6232 100644
--- a/gdb/tui/tui-win.c
+++ b/gdb/tui/tui-win.c
@@ -479,7 +479,11 @@ void
 tui_refresh_all_win (void)
 {
   clearok (curscr, TRUE);
-  tui_refresh_all ();
+  for (tui_win_info *win_info : all_tui_windows ())
+    {
+      if (win_info->is_visible ())
+	win_info->refresh_window ();
+    }
 }
 
 void

gdb/tui/tui-wingeneral.c

diff --git a/gdb/tui/tui-wingeneral.c b/gdb/tui/tui-wingeneral.c
index e4d7a68..6260d08 100644
--- a/gdb/tui/tui-wingeneral.c
+++ b/gdb/tui/tui-wingeneral.c
@@ -189,15 +189,3 @@ tui_win_info::make_visible (bool visible)
   else
     handle.reset (nullptr);
 }
-
-/* Function to refresh all the windows currently displayed.  */
-
-void
-tui_refresh_all ()
-{
-  for (tui_win_info *win_info : all_tui_windows ())
-    {
-      if (win_info->is_visible ())
-	win_info->refresh_window ();
-    }
-}

gdb/tui/tui-wingeneral.h

diff --git a/gdb/tui/tui-wingeneral.h b/gdb/tui/tui-wingeneral.h
index 6bee433..652cef9 100644
--- a/gdb/tui/tui-wingeneral.h
+++ b/gdb/tui/tui-wingeneral.h
@@ -28,7 +28,6 @@ struct tui_win_info;
 
 extern void tui_unhighlight_win (struct tui_win_info *);
 extern void tui_highlight_win (struct tui_win_info *);
-extern void tui_refresh_all ();
 
 /* An RAII class that suppresses output on construction (calling
    wnoutrefresh on the existing windows), and then flushes the output