[gdb/testsuite, tclint] Fix gdb.disasm Running tclint on the test-cases in gdb.disasm shows a few problems. Fix these. Tested on x86_64-linux.
diff --git a/gdb/testsuite/gdb.disasm/basics.exp b/gdb/testsuite/gdb.disasm/basics.exp index e54dced..9be9945 100644 --- a/gdb/testsuite/gdb.disasm/basics.exp +++ b/gdb/testsuite/gdb.disasm/basics.exp
@@ -22,7 +22,7 @@ return -1 } -if ![runto_main] { +if {![runto_main]} { return -1 }
diff --git a/gdb/testsuite/gdb.disasm/hppa.exp b/gdb/testsuite/gdb.disasm/hppa.exp index 53027d7..10b5cb5 100644 --- a/gdb/testsuite/gdb.disasm/hppa.exp +++ b/gdb/testsuite/gdb.disasm/hppa.exp
@@ -23,7 +23,7 @@ set binfile ${objdir}/${subdir}/${testfile} set comp_output [gdb_compile "${srcfile}" "${binfile}" executable ""] if { $comp_output != "" } { - if [ regexp "Opcode not defined - DIAG" $comp_output] { + if {[regexp "Opcode not defined - DIAG" $comp_output]} { warning "HP assembler in use--skipping disasm tests" return } else { @@ -686,7 +686,7 @@ } } - set subi_insns [list {subi} {subio} {comiclr} ] + set subi_insns [list {subi} {subio} {comiclr}] foreach i $subi_insns { send_gdb "x/16i $i"; send_gdb "_tests\n" @@ -746,7 +746,7 @@ timeout { fail "(timeout) "shd tests" } } - set extract_insns1 [list {extru} {extrs} {zdep} {dep} ] + set extract_insns1 [list {extru} {extrs} {zdep} {dep}] foreach i $extract_insns1 { send_gdb "x/8i $i"; send_gdb "_tests\n" @@ -766,7 +766,7 @@ } } - set extract_insns2 [list {vextru} {vextrs} {zvdep} {vdep} ] + set extract_insns2 [list {vextru} {vextrs} {zvdep} {vdep}] foreach i $extract_insns2 { send_gdb "x/8i $i"; send_gdb "_tests\n" @@ -786,7 +786,7 @@ } } - set extract_insns3 [list {vdepi} {zvdepi} ] + set extract_insns3 [list {vdepi} {zvdepi}] foreach i $extract_insns3 { send_gdb "x/8i $i"; send_gdb "_tests\n" @@ -806,7 +806,7 @@ } } - set extract_insns4 [list {depi} {zdepi} ] + set extract_insns4 [list {depi} {zdepi}] foreach i $extract_insns4 { send_gdb "x/8i $i"; send_gdb "_tests\n"