)]}'
{
  "commit": "18d4886c009aaa4fa26bf440ae57fbdd14acce11",
  "tree": "1d276143b7523576f299b3873d75953575b9013b",
  "parents": [
    "3d5394c501de9a8b1fdc11e73feb04f61c3c2eec"
  ],
  "author": {
    "name": "Andrew Burgess",
    "email": "aburgess@redhat.com",
    "time": "Fri Apr 26 14:24:40 2024 +0100"
  },
  "committer": {
    "name": "Andrew Burgess",
    "email": "aburgess@redhat.com",
    "time": "Fri Jun 14 09:08:45 2024 +0100"
  },
  "message": "gdb/x86: move have_ptrace_getfpxregs global into gdb/nat directory\n\nThe have_ptrace_getfpxregs global tracks whether GDB or gdbserver is\nrunning on a kernel that supports the GETFPXREGS ptrace request.\n\nCurrently this global is declared twice (once in GDB and once in\ngdbserver), I think it makes sense to move this global into the nat/\ndirectory, and have a single declaration and definition.\n\nWhile moving this variable I have converted it to a tribool, as that\nwas what it really was, if even used the same numbering as the tribool\nenum (-1, 0, 1).  Where have_ptrace_getfpxregs was used I have updated\nin the obvious way.\n\nHowever, while making this change I noticed what I think is a bug in\nx86_linux_nat_target::read_description and x86_linux_read_description,\nboth of these functions can be called multiple times, but in both\ncases we only end up calling i386_linux_read_description the first\ntime through in the event that PTRACE_GETFPXREGS is not supported.\nThis is because initially have_ptrace_getfpxregs will be\nTRIBOOL_UNKNOWN, but after the ptrace call fails we set\nhave_ptrace_getfpxregs to TRIBOOL_FALSE.  The next time we attempt to\nread the target description we\u0027ll skip the ptrace call, and so skip\nthe call to i386_linux_read_description.\n\nI\u0027ve not tried to address this preexisting bug in this commit, this is\npurely a refactor, there should be no user visible changes after this\ncommit.  In later commits I\u0027ll merge the gdbserver and GDB code\ntogether into the nat/ directory, and after that I\u0027ll try to address\nthis bug.\n\nReviewed-By: Felix Willgerodt \u003cfelix.willgerodt@intel.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "3752bdff79b7e93c38bd364af0c008831dcb31d3",
      "old_mode": 33188,
      "old_path": "gdb/Makefile.in",
      "new_id": "277f878371cd6eab41cddaea33dd7eff7dd50f9e",
      "new_mode": 33188,
      "new_path": "gdb/Makefile.in"
    },
    {
      "type": "modify",
      "old_id": "8b98511cef7c653cb3457755695a733d7db58e69",
      "old_mode": 33188,
      "old_path": "gdb/configure.nat",
      "new_id": "25268bb268bd1345e335c6a7e8b6ca480b3e2a17",
      "new_mode": 33188,
      "new_path": "gdb/configure.nat"
    },
    {
      "type": "modify",
      "old_id": "7278dd91ff0b93fd27e3a0794e9d28716f20ce06",
      "old_mode": 33188,
      "old_path": "gdb/i386-linux-nat.c",
      "new_id": "bfe3fb84d0a071253930a0825d5d48b2df2e8c77",
      "new_mode": 33188,
      "new_path": "gdb/i386-linux-nat.c"
    },
    {
      "type": "rename",
      "old_id": "c3d32aff1be7c9c9256031624cff6dfad84a31e8",
      "old_mode": 33188,
      "old_path": "gdb/i386-linux-nat.h",
      "new_id": "64605be4fc59a4d87f444fcfa990bf035a9a68ec",
      "new_mode": 33188,
      "new_path": "gdb/nat/i386-linux.c",
      "score": 76
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "c93626b64399da5cb76f44219d80072567c71113",
      "new_mode": 33188,
      "new_path": "gdb/nat/i386-linux.h"
    },
    {
      "type": "modify",
      "old_id": "a3d8ffb60f16663e0d366b7b42546d051ea478f1",
      "old_mode": 33188,
      "old_path": "gdb/x86-linux-nat.c",
      "new_id": "762151ff3789a69884f49908a07aefea33d175e9",
      "new_mode": 33188,
      "new_path": "gdb/x86-linux-nat.c"
    },
    {
      "type": "modify",
      "old_id": "9e861a75088a0ce073a5b2a9747d0d98d2258c93",
      "old_mode": 33188,
      "old_path": "gdbserver/configure.srv",
      "new_id": "8e882d2159b6d409e870676118979cbc8e727b63",
      "new_mode": 33188,
      "new_path": "gdbserver/configure.srv"
    },
    {
      "type": "modify",
      "old_id": "e8ef3667eb4b870af078f2683400fc8ea3c65db8",
      "old_mode": 33188,
      "old_path": "gdbserver/linux-x86-low.cc",
      "new_id": "2d99a82f5660b9740dfdee9fd84a4944457854d3",
      "new_mode": 33188,
      "new_path": "gdbserver/linux-x86-low.cc"
    }
  ]
}