)]}'
{
  "commit": "287fbf951acc76f21d5ec6ab515d6080571aa7ee",
  "tree": "a934b677af24293407c7d0682debc9469989ae21",
  "parents": [
    "7eb2a68f2854ff1b53f84346b4c19450fba21e9f"
  ],
  "author": {
    "name": "Mike Frysinger",
    "email": "vapier@gentoo.org",
    "time": "Thu Sep 09 00:46:11 2021 -0400"
  },
  "committer": {
    "name": "Mike Frysinger",
    "email": "vapier@gentoo.org",
    "time": "Thu Sep 09 01:04:08 2021 -0400"
  },
  "message": "sim: dv-sockser: move sim-main.h include after system includes\n\nThe sim-main.h header is a bit of a dumping ground.  Every arch can\n(and many do) define all sorts of weird \u0026 common names that end up\nconflicting with system headers.  So including it before the system\nheaders sets us up for pain.  v850 is a good example of this -- when\nbuilding for mingw, we see weird failures:\n\n$ i686-w64-mingw32-gcc ... -c -o dv-sockser.o ../../../../sim/v850/../common/dv-sockser.c\nIn file included from ../../../../sim/v850/sim-main.h:11,\n                 from ../../../../sim/v850/../common/dv-sockser.c:24:\n../../../../sim/v850/../common/sim-base.h:97:32: error: expected \u0027)\u0027 before \u0027-\u003e\u0027 token\n  97 | # define STATE_CPU(sd, n) ((sd)-\u003ecpu[0])\n     |                                ^~\n\nWhile gcc is unhelpful at first, running it through the preprocessor\nby hand shows more details:\n\n$ i686-w64-mingw32-gcc ... -E -dD -o dv-sockser.i ../../../../sim/v850/../common/dv-sockser.c\n$ i686-w64-mingw32-gcc -c dv-sockser.i\nIn file included from /usr/i686-w64-mingw32/usr/include/minwindef.h:163,\n                 from /usr/i686-w64-mingw32/usr/include/windef.h:9,\n                 from /usr/i686-w64-mingw32/usr/include/windows.h:69,\n                 from /usr/i686-w64-mingw32/usr/include/winsock2.h:23,\n                 from ../../gnulib/import/sys/socket.h:684,\n                 from ../../gnulib/import/netinet/in.h:43,\n                 from ../../../../sim/v850/../common/dv-sockser.c:39:\n/usr/i686-w64-mingw32/usr/include/winnt.h:4803:25: error: expected \u0027)\u0027 before \u0027-\u003e\u0027 token\n 4803 |       DWORD State;\n      |                         ^\n      |                         )\n\nThis is because v850 sets up this common name:\n\nAll of this needs cleaning up someday, but since the dv-sockser code\ndefinitely should be fixed in this way, lets do that now and unblock\nthe v850 code.\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "7f1cf798e4b947d8161927d13109f8cae9d175c0",
      "old_mode": 33188,
      "old_path": "sim/common/dv-sockser.c",
      "new_id": "99f280cd1a72b90236f3e3e532736df51b6f6da2",
      "new_mode": 33188,
      "new_path": "sim/common/dv-sockser.c"
    }
  ]
}