)]}'
{
  "commit": "30baee6865571bb0385dbc6ee7e06701e1253028",
  "tree": "d8056d8e7dcfbe90067a72743b9785904fe8cc85",
  "parents": [
    "b1c0ab20809a502b2d2224fecb0dca3ada2e9b22"
  ],
  "author": {
    "name": "Tom Tromey",
    "email": "tromey@adacore.com",
    "time": "Tue Aug 01 13:57:19 2023 -0600"
  },
  "committer": {
    "name": "Tom Tromey",
    "email": "tromey@adacore.com",
    "time": "Thu Aug 03 09:35:38 2023 -0600"
  },
  "message": "Use frame.name() in FrameDecorator\n\nA co-worker pointed out that gdb\u0027s DAP implementation might return an\ninteger for the name of a stack frame, like:\n\n    {\"id\": 1, \"name\": 93824992310799, ...}\n\nThis can be seen currently in the logs of the bt-nodebug.exp test\ncase.\n\nWhat is happening is that FrameDecorator falls back on returning the\nPC when the frame\u0027s function symbol cannot be found, relying on the\ngdb core to look up the minsym and print its name.\n\nThis can actually yield the wrong answer sometimes, because it falls\ninto the get_frame_pc / get_frame_address_in_block problem -- if the\nframe is at a call to a noreturn function, the PC in this case might\nappear to be in the next function in memory.  For more on this, see:\n\n    https://sourceware.org/bugzilla/show_bug.cgi?id\u003d8416\n\nand related bugs.\n\nHowever, there\u0027s a different approach we can take: the code here can\nsimply use Frame.name.  This handles the PC problem correctly, and\ngets us the information we need.\n\n\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "aa9a2201bec80b31587484bac57a88ee95eadbb0",
      "old_mode": 33188,
      "old_path": "gdb/python/lib/gdb/FrameDecorator.py",
      "new_id": "39ee2e2547c662602acfffa26d45273a84d01ff8",
      "new_mode": 33188,
      "new_path": "gdb/python/lib/gdb/FrameDecorator.py"
    },
    {
      "type": "modify",
      "old_id": "e4dcef35a67f60942799729d9d90c55b0eba61bb",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.dap/bt-nodebug.exp",
      "new_id": "e9726d2e17d76f563c98bac612bcd30c0a87be44",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.dap/bt-nodebug.exp"
    }
  ]
}
