)]}'
{
  "commit": "32d8e07ea75c20bafe760215f4866bc4381da78c",
  "tree": "ed2b25de8b214e46e693dbeb5750160ec7f8338b",
  "parents": [
    "d65aab93df9fa9010d2f7a2cd3f9ab07e0ac5f19"
  ],
  "author": {
    "name": "Lancelot SIX",
    "email": "lancelot.six@amd.com",
    "time": "Thu Feb 17 09:25:59 2022 +0000"
  },
  "committer": {
    "name": "Lancelot SIX",
    "email": "lancelot.six@amd.com",
    "time": "Sun Feb 20 17:21:30 2022 +0000"
  },
  "message": "gdb: Only paginate for filtered output in fputs_maybe_filtered\n\nA have had situation where a unfiltered output (done using\nfputs_unfiltered) ended up triggering pagination.  The backtrace for this was:\n\n    ...\n    #24 0x000055839377ee4e in check_async_event_handlers () at ../../gdb/async-event.c:335\n    #25 0x0000558394b67b57 in gdb_do_one_event () at ../../gdbsupport/event-loop.cc:216\n    #26 0x0000558394587454 in gdb_readline_wrapper (prompt\u003d0x7ffd907712d0 \"--Type \u003cRET\u003e for more, q to quit, c to continue without paging--\") at ../../gdb/top.c:1148\n    #27 0x0000558394707270 in prompt_for_continue () at ../../gdb/utils.c:1438\n    #28 0x00005583947088b3 in fputs_maybe_filtered (linebuffer\u003d0x60c0000f4000 \"   [...quite big message...]\", stream\u003d0x60300028e9d0, filter\u003d0) at ../../gdb/utils.c:1752\n    #29 0x0000558394708e57 in fputs_unfiltered (linebuffer\u003d0x60c0000f4000 \"   [...quite big message...]\", stream\u003d0x60300028e9d0) at ../../gdb/utils.c:1811\n    ...\n\nThis comes from what appears to be a oversight in fputs_maybe_filtered.  This\nfunction has a FILTER parameter which if true makes the function pause after\nevery screenful (i.e. triggers pagination).\n\nThe filter parameter is correctly used to guard the first place where\nprompt_for_continue.  There is a second place in the function which can call\nprompt_for_continue, but is currently unguarded.  I believe that this is an\noversight, this patch fixes that.\n\nTested on Linux-x86_64, no regression observed.\n\nChange-Id: Iad8ffd50a87cf20077500878e2564b5a7dc81ece\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "dcb42138d3978879cf25bc32ba6b528c7282c14f",
      "old_mode": 33188,
      "old_path": "gdb/utils.c",
      "new_id": "505a88aa1cd451f1cc0561f53d110714903d7c77",
      "new_mode": 33188,
      "new_path": "gdb/utils.c"
    }
  ]
}