x86: avoid string copy when swapping Vex.W controlled operands Now that op_out[] is an array of pointers, there's no need anymore to copy strings. Simply swap the pointers.
diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c index 602535d..d087b35 100644 --- a/opcodes/i386-dis.c +++ b/opcodes/i386-dis.c
@@ -13473,9 +13473,10 @@ if (ins->vex.w) { /* Swap 2nd and 3rd operands. */ - strcpy (ins->scratchbuf, ins->op_out[2]); - strcpy (ins->op_out[2], ins->op_out[1]); - strcpy (ins->op_out[1], ins->scratchbuf); + char *tmp = ins->op_out[2]; + + ins->op_out[2] = ins->op_out[1]; + ins->op_out[1] = tmp; } } @@ -13503,9 +13504,10 @@ if (ins->vex.w) { /* Swap 3rd and 4th operands. */ - strcpy (ins->scratchbuf, ins->op_out[3]); - strcpy (ins->op_out[3], ins->op_out[2]); - strcpy (ins->op_out[2], ins->scratchbuf); + char *tmp = ins->op_out[3]; + + ins->op_out[3] = ins->op_out[2]; + ins->op_out[2] = tmp; } }