)]}'
{
  "commit": "333f35b6315f6ed71db4fb76bfc1ebb7ec347d43",
  "tree": "2f6fa67e0af759a8d0f6ebaa36d1a179a9b1ec23",
  "parents": [
    "aa70a99eb03444f41f50e100c9b1e00e9a32cde9"
  ],
  "author": {
    "name": "Simon Marchi",
    "email": "simon.marchi@efficios.com",
    "time": "Tue Nov 02 12:21:31 2021 -0400"
  },
  "committer": {
    "name": "Simon Marchi",
    "email": "simon.marchi@polymtl.ca",
    "time": "Mon Nov 15 21:47:27 2021 -0500"
  },
  "message": "gdb: rework \"set debuginfod\" commands\n\nAs discussed here [1], do some re-work in the \"set debuginfod commands\".\n\nFirst, use \"set debuginfod enabled on/off/ask\" instead of \"set\ndebuginfod on/off/ask\".  This is more MI-friendly, and it gives an\noutput that makes more sense in \"info set\", for example.\n\nThen, make the show commands not call \"error\" when debuginfod support is\nnot compiled in.  This makes the commands \"show\" and \"show debuginfod\"\nstop early, breaking gdb.base/default.exp:\n\n    Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.base/default.exp ...\n    FAIL: gdb.base/default.exp: info set\n    FAIL: gdb.base/default.exp: show\n\n - Make the \"debuginfod enabled\" setting default to \"off\" when debuginfod\n   support is not compiled in, and \"ask\" otherwise.\n - Make the setter of \"debuginfod enabled\" error out when debuginfod\n   support is not compiled in, so that \"debuginfod enabled\" will always\n   remain \"off\" in that case.\n - Make the setter of \"debuginfod verbose\" work in any case.  I don\u0027t\n   see the harm in letting the user change that setting, since the user will\n   hit an error if they try to enable the use of debuginfod.\n - I would do the same for the \"debuginfod urls\" setter, but because\n   this one needs to see the DEBUGINFOD_URLS_ENV_VAR macro, provided by\n   libdebuginfod, I made that one error out as well if debuginfod\n   support is not compiled it (otherwise, I would have left it like\n   \"debuginfod verbose\".  Alternatively, we could hard-code\n   \"DEBUGINFOD_URLS\" in the code (in fact, it was prior to this patch,\n   but I think it was an oversight, as other spots use\n   DEBUGINFOD_URLS_ENV_VAR), or use a dummy string to store the setting,\n   but I don\u0027t really see the value in that.\n\nRename debuginfod_enable to debuginfod_enabled, just so it matches the\nsetting name.\n\n[1] https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html\n\nChange-Id: I45fdb2993f668226a5639228951362b7800f09d5\nCo-Authored-By: Aaron Merey \u003camerey@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "a1269772b2e288c26c392156903a6f0ea187fdec",
      "old_mode": 33188,
      "old_path": "gdb/debuginfod-support.c",
      "new_id": "2e1837da9491cac9dcc1045c0cc3a6e52a597a70",
      "new_mode": 33188,
      "new_path": "gdb/debuginfod-support.c"
    },
    {
      "type": "modify",
      "old_id": "fc8e5bdf3db65e1c396dad08cb3ff4af3d1ae725",
      "old_mode": 33188,
      "old_path": "gdb/doc/gdb.texinfo",
      "new_id": "f6d221f003e4abbd52f5206e4d6ca43eb15cf9c0",
      "new_mode": 33188,
      "new_path": "gdb/doc/gdb.texinfo"
    },
    {
      "type": "modify",
      "old_id": "31e9e4a92f0c37039a62957162c74498443cf0c5",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp",
      "new_id": "757bd201b178de1327455d010a01fcb73fd73b08",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp"
    }
  ]
}