)]}'
{
  "commit": "4f440ff33d1cf8812d4f652f6fddbfa3d117268e",
  "tree": "5709e9cadba2afb6f21130c0c1fa187e62fee2ff",
  "parents": [
    "5792be924413fcd2195242d87252857b888086dd"
  ],
  "author": {
    "name": "Andrew Burgess",
    "email": "aburgess@redhat.com",
    "time": "Tue Jan 16 12:21:52 2024 +0000"
  },
  "committer": {
    "name": "Andrew Burgess",
    "email": "aburgess@redhat.com",
    "time": "Mon Mar 25 17:47:43 2024 +0000"
  },
  "message": "gdb: allow double quotes for quoting filenames\n\nCurrently GDB only supports using single quotes for quoting things,\nthe reason for this, as explained in completer.c (next to the variable\ngdb_completer_expression_quote_characters) is that double quoted\nstrings need to be treated differently by the C expression parser.\n\nBut for filenames I don\u0027t believe this restriction holds.  The file\nnames as passed to things like the \u0027file\u0027 command are not passing\nthrough the C expression parser, so it seems like we should be fine to\nallow double quotes for quoting in this case.\n\nAnd so, this commit extends GDB to allow double quotes for quoting\nfilenames.  Maybe in future we might be able to allow double quote\nquoting in additional places, but this seems enough for now.\n\nThe testing has been extended to cover double quotes in addition to\nthe existing single quote testing.\n\nThis change does a number of things:\n\n 1. Set rl_completer_quote_characters in filename_completer and\n filename_completer_handle_brkchars, this overrides the default which\n is set in complete_line_internal_1,\n\n 2. In advance_to_completion_word we now take a set of quote\n characters as a parameter, the two callers\n advance_to_expression_complete_word_point and\n advance_to_filename_complete_word_point now pass in the required set\n of quote characters,\n\n 3. In completion_find_completion_word we now use the currently active\n set of quote characters, this means we\u0027ll use\n gdb_completer_expression_quote_characters or\n gdb_completer_file_name_quote_characters depending on what type of\n things we are completing.\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "44da6548eb44f9505f7a6165648c3c6ee584ca0b",
      "old_mode": 33188,
      "old_path": "gdb/completer.c",
      "new_id": "cefac605a33ddd9784acb7af5917982679bf2100",
      "new_mode": 33188,
      "new_path": "gdb/completer.c"
    },
    {
      "type": "modify",
      "old_id": "7d8ab1a33500b616481fd89a17bda87a09bba112",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.base/filename-completion.exp",
      "new_id": "b700977cec57ad799acbf068f14fd0859918d996",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/filename-completion.exp"
    }
  ]
}