)]}'
{
  "commit": "5f0e2eb79e6b771779eab6f5a8cf33c5c889ca85",
  "tree": "c1389c72a2187e9be219898256c3b3585dbbc2e7",
  "parents": [
    "33176d912add7680277ad5e18af0e6303d9a7af8"
  ],
  "author": {
    "name": "Maciej W. Rozycki",
    "email": "macro@wdc.com",
    "time": "Mon Feb 10 08:59:04 2020 +0000"
  },
  "committer": {
    "name": "Maciej W. Rozycki",
    "email": "macro@wdc.com",
    "time": "Mon Feb 10 08:59:04 2020 +0000"
  },
  "message": "GDB/testsuite: Fix a catastrophic step-over-no-symbols.exp failure\n\nFix a catastrophic failure in gdb.base/step-over-no-symbols.exp where\nremote target communication issues cause the value of the PC retrieved\nto be empty:\n\n(gdb) FAIL: gdb.base/step-over-no-symbols.exp: displaced\u003doff: stepi\np /x $pc\nRemote \u0027g\u0027 packet reply is too long (expected 264 bytes, got 532 bytes): 00000000000000002a6f61551500000080faffff3f0000000028010000000000b03857551500000060ad5f5515000000906e615515000000802401000000000090faffff3f00000000000000000000000100000000000000e8fbffff3f000000f8fbffff3f0000000000000000000000b8faffff3f0000008a05010000000000589c6f551500000056424d40435c2f7c1809575515000000f0e0baaa2a0000000000000000000000f0ffbaaa2a000000f0e0baaa2a0000006804baaa2a000000000000000000000000000000000000007053baaa2a0000008252b2aa2a00000090fe01000000000048e056551500000004000000000000004000000000000000920501000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000xxxxxxxxxxxxxxxx00000000\n(gdb) FAIL: gdb.base/step-over-no-symbols.exp: displaced\u003doff: get after PC\nERROR: tcl error sourcing .../gdb/testsuite/gdb.base/step-over-no-symbols.exp.\nERROR: missing operand at _@_\nin expression \" _@_!\u003d \"\n    (parsing expression \" !\u003d \")\n    invoked from within\n\"expr $before_addr !\u003d $after_addr\"\n    (\"uplevel\" body line 1)\n    invoked from within\n\"uplevel 1 expr $condition\"\n    (procedure \"gdb_assert\" line 6)\n    invoked from within\n\"gdb_assert {$before_addr !\u003d $after_addr} \"advanced\"\"\n    (procedure \"test_step_over\" line 36)\n    invoked from within\n\"test_step_over $displaced\"\n    (\"uplevel\" body line 2)\n    invoked from within\n\"uplevel 1 $body\"\n    invoked from within\n\"with_test_prefix \"displaced\u003d$displaced\" {\n\ttest_step_over $displaced\n    }\"\n    (\"foreach\" body line 6)\n    invoked from within\n\"foreach displaced { \"off\" \"on\" \"auto\" } {\n    if { $displaced !\u003d \"off\" \u0026\u0026 ![support_displaced_stepping] } {\n\tcontinue\n    }\n\n    with_test_prefix \"dis...\"\n    (file \".../gdb/testsuite/gdb.base/step-over-no-symbols.exp\" line 84)\n    invoked from within\n\"source .../gdb/testsuite/gdb.base/step-over-no-symbols.exp\"\n    (\"uplevel\" body line 1)\n    invoked from within\n\"uplevel #0 source .../gdb/testsuite/gdb.base/step-over-no-symbols.exp\"\n    invoked from within\n\"catch \"uplevel #0 source $test_file_name\"\"\nRemote debugging from host xxx.xxx.xxx.xxx, port 47130\nmonitor exit\nKilling process(es): 1092\nRemote communication error.  Target disconnected.: Connection reset by peer.\n(gdb)\n\nTo do so verify first, before making an arithmetic comparison, that the\nvalues to compare are actually integers (using a string comparison would\nresult in a false PASS if both operands were empty, as in this case),\nmaking the test script proceed normally:\n\n(gdb) FAIL: gdb.base/step-over-no-symbols.exp: displaced\u003doff: stepi\np /x $pc\nRemote \u0027g\u0027 packet reply is too long (expected 264 bytes, got 532 bytes): 00000000000000002a6f61551500000080faffff3f0000000028010000000000b03857551500000060ad5f5515000000906e615515000000802401000000000090faffff3f00000000000000000000000100000000000000e8fbffff3f000000f8fbffff3f0000000000000000000000b8faffff3f0000008a05010000000000589c6f5515000000424d40435c2f7c7c1809575515000000f0e0baaa2a0000000000000000000000f0ffbaaa2a000000f0e0baaa2a0000006804baaa2a000000000000000000000000000000000000007053baaa2a0000008252b2aa2a00000090fe01000000000048e056551500000004000000000000004000000000000000920501000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000xxxxxxxxxxxxxxxx00000000\n(gdb) FAIL: gdb.base/step-over-no-symbols.exp: displaced\u003doff: get after PC\nFAIL: gdb.base/step-over-no-symbols.exp: displaced\u003doff: advanced\nRemote debugging from host xxx.xxx.xxx.xxx, port 48404\nmonitor exit\nKilling process(es): 1795\nRemote communication error.  Target disconnected.: Connection reset by peer.\n(gdb)\n\nNote the double curly braces, to take advantage of `\u0026\u0026\u0027 operator\u0027s lazy\nevaluation.\n\n\tgdb/testsuite/\n\t* gdb.base/step-over-no-symbols.exp: Verify that $before_addr\n\tand $after_addr are both integers before making a comparison.\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "42c8e8f11ef6a7b5dacef90b9febb3be60acc312",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/ChangeLog",
      "new_id": "ef439953052791695c8ccdd0b8fd7d295590e2bc",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/ChangeLog"
    },
    {
      "type": "modify",
      "old_id": "44b993a3d392a66c68b21cce74b36414ae0d2ba1",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.base/step-over-no-symbols.exp",
      "new_id": "bc715d7afed15926526374905daaf81973cc8191",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/step-over-no-symbols.exp"
    }
  ]
}