)]}'
{
  "commit": "5f8ab46bc6918efb678deb5956c033e466afe301",
  "tree": "d26ed3310c2665b23ae6778aa395fdd7d886f832",
  "parents": [
    "7055fa96fcadf77482876b42393fe43b48fdfe16"
  ],
  "author": {
    "name": "Simon Marchi",
    "email": "simon.marchi@polymtl.ca",
    "time": "Mon Jan 31 15:57:58 2022 -0500"
  },
  "committer": {
    "name": "Simon Marchi",
    "email": "simon.marchi@polymtl.ca",
    "time": "Sun Mar 06 11:33:23 2022 -0500"
  },
  "message": "gdb: constify parameter of value_copy\n\nIn a following patch, I have a const value I want to copy using a\nvalue_copy.  However, value_copy takes a non-const source value, at the\nmoment.  Change the paramter to be const,\n\nIf the source value is not lazy, we currently call\nvalue_contents_all_raw, which calls allocate_value_contents, to get a\nview on the contents.  They both take a non-const value, that\u0027s a\nproblem.  My first attempt at solving it was to add a const version of\nvalue_contents_all_raw, make allocate_value_contents take a const value,\nand either:\n\n - make value::contents mutable\n - make allocate_value_contents cast away the const\n\nThe idea being that allocating the value contents buffer does modify the\nvalue at the bit level, but logically that doesn\u0027t change its state.\n\nThat was getting a bit complicated, so what I ended up doing is make\nvalue_copy not call value_contents_all_raw.  We know at this point that\nthe value is not lazy, so value::contents must have been allocate\nalready.\n\nChange-Id: I3741ab362bce14315f712ec24064ccc17e3578d4\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "080af487c56755882aa0f1df6ae83e6c00cd8912",
      "old_mode": 33188,
      "old_path": "gdb/value.c",
      "new_id": "a57a83207e29ef7a5ffe6005037dd771e66dce84",
      "new_mode": 33188,
      "new_path": "gdb/value.c"
    },
    {
      "type": "modify",
      "old_id": "f7b29022d37cf445cc10807ca79982ff6ec5dfe1",
      "old_mode": 33188,
      "old_path": "gdb/value.h",
      "new_id": "4cd2044ac7cff23054ed0f23c106a878f2c455f0",
      "new_mode": 33188,
      "new_path": "gdb/value.h"
    }
  ]
}