)]}'
{
  "commit": "694e0267385907eaa5620ae7fc65f5e2f265d9f0",
  "tree": "5c08deacbefcab34eb26e679a8208c77dd5df056",
  "parents": [
    "37491e34f0652e48879d4551e61239ba905cba0b"
  ],
  "author": {
    "name": "Pedro Alves",
    "email": "pedro@palves.net",
    "time": "Wed Jun 24 14:45:56 2026 +0100"
  },
  "committer": {
    "name": "Pedro Alves",
    "email": "pedro@palves.net",
    "time": "Mon Jul 06 23:37:35 2026 +0100"
  },
  "message": "Windows/rocm-solib: Don\u0027t hardcode namespaces support\n\nrocm_solib_ops currently unconditionally returns true to\nsolib_ops::supports_namespaces.  That works OK on Linux where the\nunderlying solib ops is svr4.  But on Windows, the underlying solib\nops is solib-target, which does not support namespaces.  The result\nis:\n\n (gdb) info shared\n /home/pedro/rocm/gdb/build/gdb/solib.h:270: internal-error: num_active_namespaces: namespaces not supported\n A problem internal to GDB has been detected,\n further debugging may prove unreliable.\n ...\n Thread 1 hit Breakpoint 1, internal_verror (file\u003d0x7ff71a27fc80 \u003cSCRIPTING_SEARCH_FLAG+52\u003e \"/home/pedro/rocm/gdb/build/gdb/solib.h\", line\u003d270,\n     fmt\u003d0x7ff71a27fc5e \u003cSCRIPTING_SEARCH_FLAG+18\u003e \"%s: namespaces not supported\", ap\u003d0xfff1a8 \"\\270\\374\u0027\", \u003cincomplete sequence \\367\\177\u003e)\n     at /home/pedro/rocm/gdb/build/gdb/utils.c:514\n 514       internal_vproblem (\u0026internal_error_problem, file, line, fmt, ap);\n (gdb) bt\n #0  internal_verror (file\u003d0x7ff71a27fc80 \u003cSCRIPTING_SEARCH_FLAG+52\u003e \"/home/pedro/rocm/gdb/build/gdb/solib.h\", line\u003d270,\n     fmt\u003d0x7ff71a27fc5e \u003cSCRIPTING_SEARCH_FLAG+18\u003e \"%s: namespaces not supported\", ap\u003d0xfff1a8 \"\\270\\374\u0027\", \u003cincomplete sequence \\367\\177\u003e)\n     at /home/pedro/rocm/gdb/build/gdb/utils.c:514\n #1  0x00007ff719c75cf4 in internal_error_loc (file\u003d0x7ff71a27fc80 \u003cSCRIPTING_SEARCH_FLAG+52\u003e \"/home/pedro/rocm/gdb/build/gdb/solib.h\", line\u003d270,\n     fmt\u003d0x7ff71a27fc5e \u003cSCRIPTING_SEARCH_FLAG+18\u003e \"%s: namespaces not supported\") at /home/pedro/rocm/gdb/build/gdbsupport/errors.cc:57\n #2  0x00007ff719f0aafe in solib_ops::num_active_namespaces (this\u003d0xbb3a0b0) at /home/pedro/rocm/gdb/build/gdb/solib.h:270\n #3  0x00007ff719eca99e in rocm_solib_ops::num_active_namespaces (this\u003d0xc9388a0) at /home/pedro/rocm/gdb/build/gdb/solib-rocm.c:211\n #4  0x00007ff719a14d33 in print_solib_list_table (solib_list\u003d..., print_namespace\u003dtrue) at /home/pedro/rocm/gdb/build/gdb/solib.c:1011\n #5  0x00007ff719a15833 in info_sharedlibrary_command (pattern\u003d0x0, from_tty\u003d1) at /home/pedro/rocm/gdb/build/gdb/solib.c:1115\n\nrocm_solib_ops will stop sitting on top of another solib\nimplementation once the multi solib provider work lands, but\nmeanwhile, it\u0027d be helpful to not crash.\n\nFix this by making rocm_solib_ops::supports_namespaces() delegate to\nthe underlying host solib ops like other methods do.\n\nApproved-by: Lancelot Six \u003clancelot.six@amd.com\u003e (amdgpu)\nChange-Id: I1627c6e2f1b1c171c013c8457e9bfca92d5f4dc5\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "3a58a46d886b9a677b71c139c4a462e40f7012ac",
      "old_mode": 33188,
      "old_path": "gdb/solib-rocm.c",
      "new_id": "73797801d6cda083e9427bb0dec1b636d7490b84",
      "new_mode": 33188,
      "new_path": "gdb/solib-rocm.c"
    }
  ]
}