)]}'
{
  "commit": "72ab7ac8be993e29f8a393b72dc681d627b12d19",
  "tree": "d22e9b1773d7dbc3e0f91ae7a11df7d1fde06e2d",
  "parents": [
    "85041a8d518b4e0625b2bb1d007838dfd5cbe421"
  ],
  "author": {
    "name": "Tom de Vries",
    "email": "tdevries@suse.de",
    "time": "Mon Mar 11 10:57:31 2024 +0100"
  },
  "committer": {
    "name": "Tom de Vries",
    "email": "tdevries@suse.de",
    "time": "Mon Mar 11 10:57:31 2024 +0100"
  },
  "message": "gdb/testsuite: Fix gdb.threads/threadcrash.exp with check-readmore\n\nWith check-readmore, I run into:\n...\nFAIL: gdb.threads/threadcrash.exp: test_corefile: \\\n  $thread_count \u003d\u003d [llength $test_list]\n...\n\nThe problem is that the clauses in the gdb_test_multiple for\n\"thread apply all backtrace\" intent to match one line, but actually can\nmatch more than one line, and consequently a match for one type of thread can\nconsume a line that was supposed to match another thread.\n\nFor instance, there\u0027s this regexp:\n...\n\t    -re \"\\[^\\n\\]*syscall_task .location\u003dSIGNAL_ALT_STACK\\[^\\n\\]*\" {\n...\n\nIt\u0027s limited at the end by \\[^\\n\\]*, meaning the match stops at the end of the\nline.\n\nBut it doesn\u0027t start with a ^, and consequently can match more than one line.\nThe \"\\[^\\n\\]*\" at the start doesn\u0027t prevent this, there\u0027s an implicit .* at\nthe start of each pattern, unless it\u0027s anchored using a ^.\n\nFix this by rewriting the regexps in a \"^\\r\\n$hs$regexp$hs$eol\" style, where:\n- hs is: \\[^\\n\\]* (horizontal space), and\n- eol is (?\u003d\\r\\n) (look-ahead end-of-line).\n\nIt also turned out to be necessary to drop the -lbl switch, and introduce a\ncorresponding explicit clause.  The -lbl clause is placed ALAP, and\nconsequently allowed the default fail clause to trigger.\n\nTested on arm-linux and x86_64-linux.\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "3d269ec88c51f976343035c745e0c85872e2a8fd",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.threads/threadcrash.exp",
      "new_id": "592098b9c3838c8147a1068a9976f64dbe43bac3",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.threads/threadcrash.exp"
    }
  ]
}
