)]}'
{
  "commit": "755251522afd2f33de7e64f8a30ddd732f30b2de",
  "tree": "68a727dfb7b98add42281143cc0dc29d5051c901",
  "parents": [
    "e94e944bf2834d9bceafa1e1e4246bfa87b89677"
  ],
  "author": {
    "name": "Tom de Vries",
    "email": "tdevries@suse.de",
    "time": "Fri Feb 21 20:47:28 2020 +0100"
  },
  "committer": {
    "name": "Tom de Vries",
    "email": "tdevries@suse.de",
    "time": "Fri Feb 21 20:47:28 2020 +0100"
  },
  "message": "[gdb/testsuite] Fix gdb.go/methods.exp\n\nWith gccgo-6/7, we have:\n...\nFAIL: gdb.go/methods.exp: setting breakpoint at main.T.Foo\nXFAIL: gdb.go/methods.exp: going to first breakpoint \\\n  (the program exited)\nFAIL: gdb.go/methods.exp: setting breakpoint at (*main.T).Bar\nXFAIL: gdb.go/methods.exp: going to second breakpoint \\\n  (the program is no longer running)\n...\n\nAnd with gccgo-8/9/10, we have:\n...\nPASS: gdb.go/methods.exp: setting breakpoint 1\nXFAIL: gdb.go/methods.exp: going to first breakpoint\nFAIL: gdb.go/methods.exp: setting breakpoint at (*main.T).Bar\nXFAIL: gdb.go/methods.exp: going to second breakpoint \\\n  (the program exited)\n...\n\nThe first test passes and fails with different messages:\n...\nFAIL: gdb.go/methods.exp: setting breakpoint at main.T.Foo\n...\nor:\n...\nPASS: gdb.go/methods.exp: setting breakpoint 1\n...\nFix this by removing the explicit pass call and using the message argument for\ngdb_breakpoint, for both breakpoint locations.\n\nThe setup of the xfails is non-specific:\n...\nsetup_xfail \"*-*-*\" ;# mangling issues IIRC\n...\nso let\u0027s start with removing these.\n\nThe first FAIL with gccgo-6:\n...\nFAIL: gdb.go/methods.exp: setting breakpoint at main.T.Foo\n...\nis due an incorrect DW_AT_name attribute:\n...\n    #    \u003c554\u003e   DW_AT_name        : main.Foo.N6_main.T\n...\nFix this by recognizing the incorrect attribute, and xfailing the test.\n\nFurthermore, if setting the breakpoint fails, there\u0027s not much point in trying\nto continue to the breakpoint:\n...\nFAIL: gdb.go/methods.exp: setting breakpoint at main.T.Foo\nFAIL: gdb.go/methods.exp: going to first breakpoint (the program exited)\n...\nFix this by skipping the second test if the first one fails, also for the\nsecond breakpoint.\n\nWith gccgo-10, we manage to set the first breakpoint, but continuing to\nbreakpoint test fails:\n...\nPASS: gdb.go/methods.exp: setting breakpoint 1\nFAIL: gdb.go/methods.exp: going to first breakpoint\n...\nThis is due to an incorrect regexp, requiring a colon in front of the\nbreakpoint location.  Fix this for both breakpoints.\n\nSetting the second breakpoint fails:\n...\nFAIL: gdb.go/methods.exp: setting breakpoint at (*main.T).Bar\n...\npresumably because the breakpoint location \"(*main.T).Bar\" does not follow the\nnaming convention explained at https://golang.org/doc/gdb#Naming.  Fix this by\nupdating the breakpoint location to \"main.(*T).Bar\".\n\nStill this test fails, for gccgo-6/7 because of an incorrect DW_AT_name\nattribute:\n...\n    # \u003c529\u003e   DW_AT_name        : main.Bar.pN6_main.T\n...\nand for gccgo-8/9/10 because of incorrect DW_AT_name/DW_AT_linkage_name\nattributes (filed as gcc PR93866):\n...\n    #    \u003c6e5\u003e   DW_AT_name        : main.Bar..1main.T\n    #    \u003c6ec\u003e   DW_AT_linkage_name: main.T.Bar\n..\nAdd xfails for both of these.\n\nAll in all, now we have with gccgo-6/7:\n...\nXFAIL: gdb.go/methods.exp: setting breakpoint at main.T.Foo\nXFAIL: gdb.go/methods.exp: setting breakpoint at main.(*T).Bar\n...\nand with gccgo-8/9/10, we have:\n...\nPASS: gdb.go/methods.exp: setting breakpoint at main.T.Foo\nPASS: gdb.go/methods.exp: going to first breakpoint\nXFAIL: gdb.go/methods.exp: setting breakpoint at main.(*T).Bar\n...\n\nTested on x86_64-linux with gccgo-6/7/8/9/10.\n\ngdb/testsuite/ChangeLog:\n\n2020-02-21  Tom de Vries  \u003ctdevries@suse.de\u003e\n\n\tPR go/18926\n\t* lib/gdb.exp (bp_location2/bp_location2_regexp): Fix.\n\tRemove blanket xfails.  Use message argument for gdb_breakpoint.\n\tMake continuing to breakpoint test conditional on setting breakpoint.\n\tFix continuing to breakpoint regexp.  Add xfails for gccgo-6/7\n\tDW_AT_name attribute.  Add xfail for GCC PR93866.\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "6e9f94ff973e9a7871c38dfda9ee1ac68f9cdfde",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/ChangeLog",
      "new_id": "5dd1d3386a524dd5f644f920a113299191481f09",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/ChangeLog"
    },
    {
      "type": "modify",
      "old_id": "e698cf378fd90440076491a2367b8de4f7944b9b",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.go/methods.exp",
      "new_id": "b24ee14cf2cf3e10c6bb9621b9ac0607c632429e",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.go/methods.exp"
    }
  ]
}