)]}'
{
  "commit": "75d277b1f506dcfbedfee3bef078dfe2b484958b",
  "tree": "41e07d5def6d730605936d34e33ecf92ee7d0076",
  "parents": [
    "0f077fcae0f1b090439169c471bba29b3be86615"
  ],
  "author": {
    "name": "Tom de Vries",
    "email": "tdevries@suse.de",
    "time": "Wed Apr 17 11:45:02 2024 +0200"
  },
  "committer": {
    "name": "Tom de Vries",
    "email": "tdevries@suse.de",
    "time": "Wed Apr 17 11:45:02 2024 +0200"
  },
  "message": "[gdb/testsuite] Fix gdbserver pid in gdb.server/server-kill-python.exp\n\nThe commit ed32754a8c7 (\"[gdb/testsuite] Fix gdb.server/multi-ui-errors.exp for\nremote target\") intended to addresss the problem that this command:\n...\nset gdbserver_pid [exp_pid -i $server_spawn_id]\n...\ndoes not return the pid of the gdbserver for remote target, but rather the one\nof the ssh client session.\n\nTo fix this, it added another way of getting the gdbserver_pid.\n\nFor the trivial case of non-remote target, the PID found by either method\nshould be identical, but if we compare those by adding\n\"puts [exec ps -p $gdbserver_pid]\" we get:\n...\n  PID TTY          TIME CMD\n31711 pts/8    00:00:00 gdbserver\n  PID TTY          TIME CMD\n31718 pts/8    00:00:00 server-kill-pyt\n...\n\nThe problem is that while the gdbserver PID is supposed to be read from the\nresult of \"gdb.execute (\u0027p server_pid\u0027)\" in the python script, instead it\u0027s\ntaken from:\n...\nProcess server-kill-python created; pid \u003d 31718^M\n...\n\nFix this by moving the printing of the gdbserver PID out of the python script.\n\nAlso double-check the two methods against each other, in the cases that they\nshould match.\n\nTested on x86_64-linux.\n\nPR testsuite/31633\nhttps://sourceware.org/bugzilla/show_bug.cgi?id\u003d31633\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "87f9b56bd39262225e8557ef24bba5ec9a8d298e",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.server/server-kill-python.exp",
      "new_id": "f02c69c502f8fc0549dee5069cac24428a2d3cef",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.server/server-kill-python.exp"
    }
  ]
}
