)]}'
{
  "commit": "7699dfc8d5896556e700bd6cb36d76dd43252e98",
  "tree": "e9cbe9291c0479c44f3413de5aae2d3096b1952b",
  "parents": [
    "0f2cd53cf4f730136e2b275e8279d8bc348a9a88"
  ],
  "author": {
    "name": "Simon Marchi",
    "email": "simon.marchi@efficios.com",
    "time": "Tue Oct 25 09:50:56 2022 -0400"
  },
  "committer": {
    "name": "Simon Marchi",
    "email": "simon.marchi@efficios.com",
    "time": "Tue Oct 25 10:36:23 2022 -0400"
  },
  "message": "gdb/testsuite: make sure to consume the prompt in gdb.base/unwind-on-each-insn.exp\n\nThis test fails quite reliably for me when ran as:\n\n    $ taskset -c 1 make check TESTS\u003d\"gdb.base/unwind-on-each-insn.exp\" RUNTESTFLAGS\u003d\"--target_board\u003dnative-gdbserver\"\n\nor more simply:\n\n    $ make check-read1 TESTS\u003d\"gdb.base/unwind-on-each-insn.exp\"\n\nThe problem is that the gdb_test_multiple call that grabs the frame id\nfrom \"maint print frame-id\" does not consume the prompt.  Well, it does\nsometimes due to the trailing .*, but not always.  If the prompt is not\nconsumed, the tests that follow get confused:\n\n    FAIL: gdb.base/unwind-on-each-insn.exp: gdb_breakpoint: set breakpoint at *foo\n    FAIL: gdb.base/unwind-on-each-insn.exp: disassemble foo\n    FAIL: gdb.base/unwind-on-each-insn.exp: get $sp and frame base in foo: get hexadecimal valueof \"$sp\"\n    ... many more ...\n\nUse -wrap to make gdb_test_multiple consume the prompt.\n\nWhile at it, remove the bit that consumes the command name and do\nexp_continue, it\u0027s not really necessary.  And for consistency, do the\nsame changes to the gdb_test_multiple that consumes the stack address,\nalthough that one was fine, it did consume the prompt explicitly.\n\nChange-Id: I2b7328c8844c7e98921ea494c4c05107162619fc\nReviewed-By: Bruno Larsen \u003cblarsen@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "faa6a1a3f064e22523cc0fd323b4dee04585d341",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.base/unwind-on-each-insn.exp",
      "new_id": "3b48805cff83e379ef8f1b1f26207c2b4366ca30",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/unwind-on-each-insn.exp"
    }
  ]
}
