commit 7b91a240d6e0c1a2766276ecfbfabde4a68420a5
author Piotr Rudnicki <piotr.rudnicki@intel.com> Fri May 30 15:14:47 2025 +0200
committer Piotr Rudnicki <piotr.rudnicki@intel.com> Tue Jun 03 09:50:03 2025 +0200
tree 79d3ec7b2917775bc21be550597bc040c76845f6
parent c6115b5eacda61abe76b05f610eea38eb3dbbfb3

gdb: remove unused argument in evaluate_subexp_for_address_base

Remove the unused 'struct expression *exp' parameter from
evaluate_subexp_for_address_base and also do some format cleanup.

gdb/eval.c

diff --git a/gdb/eval.c b/gdb/eval.c
index 19770ad..7601c3b 100644
--- a/gdb/eval.c
+++ b/gdb/eval.c
@@ -2558,12 +2558,10 @@ unop_extract_operation::evaluate (struct type *expect_type,
 
 }
 
-
 /* Helper for evaluate_subexp_for_address.  */
 
 static value *
-evaluate_subexp_for_address_base (struct expression *exp, enum noside noside,
-				  value *x)
+evaluate_subexp_for_address_base (enum noside noside, value *x)
 {
   if (noside == EVAL_AVOID_SIDE_EFFECTS)
     {
@@ -2571,14 +2569,13 @@ evaluate_subexp_for_address_base (struct expression *exp, enum noside noside,
 
       if (TYPE_IS_REFERENCE (type))
 	return value::zero (lookup_pointer_type (type->target_type ()),
-			   not_lval);
+			    not_lval);
       else if (x->lval () == lval_memory || value_must_coerce_to_target (x))
-	return value::zero (lookup_pointer_type (x->type ()),
-			   not_lval);
+	return value::zero (lookup_pointer_type (x->type ()), not_lval);
       else
-	error (_("Attempt to take address of "
-		 "value not located in memory."));
+	error (_("Attempt to take address of value not located in memory."));
     }
+
   return value_addr (x);
 }
 
@@ -2598,7 +2595,7 @@ value *
 operation::evaluate_for_address (struct expression *exp, enum noside noside)
 {
   value *val = evaluate (nullptr, exp, noside);
-  return evaluate_subexp_for_address_base (exp, noside, val);
+  return evaluate_subexp_for_address_base (noside, val);
 }
 
 value *
@@ -2625,7 +2622,7 @@ unop_ind_base_operation::evaluate_for_address (struct expression *exp,
   if (unop_user_defined_p (UNOP_IND, x))
     {
       x = value_x_unop (x, UNOP_IND, noside);
-      return evaluate_subexp_for_address_base (exp, noside, x);
+      return evaluate_subexp_for_address_base (noside, x);
     }
 
   return coerce_array (x);