)]}'
{
  "commit": "880853ed941dc1154e3bb2bd44ddd10b84dfecff",
  "tree": "f862234c33c3ae6738512e6ca642f83e26087e4a",
  "parents": [
    "b196c8b3b6027714f50f75c1278843ee0e38d6de"
  ],
  "author": {
    "name": "Alan Modra",
    "email": "amodra@gmail.com",
    "time": "Fri May 19 17:40:30 2023 +0930"
  },
  "committer": {
    "name": "Alan Modra",
    "email": "amodra@gmail.com",
    "time": "Sat May 20 10:49:19 2023 +0930"
  },
  "message": "tic54x set_arch_mach\n\nThe tic54x backend provides its own coff_set_arch_mach, but wants to\nuse the standard coff_set_section_contents.  BFD_JUMP_TABLE_WRITE\ndefines both of these functions, so the code also provides a wrapper\nfor coff_set_section_contents.  This is all quite OK, but I was on a\nmission to remove unnecessary declarations in coffcode.h, and on\ndeleting the one for coff_set_arch_mach ran into a warning about the\nfunction being unused.  I could have kept that declaration with its\nATTRIBUTE_UNUSED or written \"static bool ATTRIBUTE_UNUSED\" on the\ndefinition but the latter is not usual and looks odd to me.  So I\nhad a closer look at tic54x_set_arch_mach and decided the function is\nvery likely wrong to allow bfd_arch_unknown.  Thus the backend should\nbe using the standard coff_set_arch_mach.\n\n\t* coff-tic54x.c: Use BFD_JUMP_TABLE_WRITE (coff) in target vecs.\n\t(tic54x_coff_set_arch_mach): Delete.\n\t(tic54x_set_section_contents): Delete.\n\t* coffcode.h: Delete unnecessary forward declarations.\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "77d99948deffc8e0a443de739b25659dbafdb583",
      "old_mode": 33188,
      "old_path": "bfd/coff-tic54x.c",
      "new_id": "55f87a1b6e5d9bb014319b66a98f2d202f500557",
      "new_mode": 33188,
      "new_path": "bfd/coff-tic54x.c"
    },
    {
      "type": "modify",
      "old_id": "2d4298288220d5aabd0f96ec31dab95104ea2ba7",
      "old_mode": 33188,
      "old_path": "bfd/coffcode.h",
      "new_id": "ab22ed092d64b436c9ec7400b1649e292030697d",
      "new_mode": 33188,
      "new_path": "bfd/coffcode.h"
    }
  ]
}