tree 1705854987ae5437dd889d6013d1eadfcba7af9a
parent 7fcc471ca223871e5d11ab7bc19be33c2d178ef8
author Nelson Chu <nelson@rivosinc.com> 1702264055 +0800
committer Nelson Chu <nelson@rivosinc.com> 1702265539 +0800

RISC-V/gas: Clarify the definition of `relaxable' in md_apply_fix

The `relaxable' in md_apply_fix means if the relocation can be relaxed or not
in link-time generally.  We can use `.option relax/norelax' to enable/disable
relaxations for some specific areas, so the value of `riscv_opts.relax'
will be changed dynamically.  The `fixP->fx_tcbit' records the correct value
of `riscv_opts.relax' for every relocation.  Therefore, set `relaxable' to
`riscv_opts.relax' will cause unexpected behavior for the following case,

.option norelax
lla a1, foo1
.option relax
lla a2, foo2
.option norelax
lla a3, foo3

For the current assembler, the final value of `riscv_opts.relax' is false, so
the second `lla a2, foo2' won't have R_RISCV_RELAX relocation, but should have.

gas/
	* config/tc-riscv.c (md_apply_fix): Set the value of `relaxable' to
	`riscv_opts.relax' is wrong.  It should be `true' generally.