tree d89663b14c85b39ce87739b3f65b2d9d012a2b01
parent e2e6bf023e856831fefb6c7f9b4aee9283c6dde7
author Simon Marchi <simon.marchi@efficios.com> 1715877353 -0400
committer Simon Marchi <simon.marchi@polymtl.ca> 1715880349 -0400

gdb: initialize packet_result::m_textual_err_msg

When building GDB with -O2 and --enable-ubsan, I get some random errors
in the packet_result self test:

  /home/smarchi/src/binutils-gdb/gdb/remote.c:161:7: runtime error: load of value 92, which is not a valid value for type 'bool'

This happens because packet_result::m_textual_err_msg is uninitialized
when using the second constructor.  When such a packet_result object
gets copied, an invalid value for m_textual_err_msg (a bool field) is
loaded, which triggers ubsan.

Avoid this by initializing m_textual_err_msg.

Change-Id: I3ce44816bb0bfc6e442067292f993e5c17301b85
Approved-By: Tom Tromey <tom@tromey.com>