)]}'
{
  "commit": "8cb2c7fc2ea4b40494b9be0f446bfbb2e52e057d",
  "tree": "73e59f17c0e01f14c6978310cd5acac5dc934ffb",
  "parents": [
    "dbbfabb441556497f3ee9d89cf74bdc4a7a4c83c"
  ],
  "author": {
    "name": "Simon Marchi",
    "email": "simon.marchi@efficios.com",
    "time": "Thu Nov 02 23:19:09 2023 -0400"
  },
  "committer": {
    "name": "Simon Marchi",
    "email": "simon.marchi@efficios.com",
    "time": "Fri Nov 03 14:27:26 2023 -0400"
  },
  "message": "gdbsupport: mark array_view::slice with [[nodiscard]]\n\nI (almost) had a bug where I did:\n\n    buffer.slice (...)\n\nbut I meant:\n\n    buffer \u003d buffer.slice (...)\n\nThe first one does nothing, it creates a new array_view but without\nusing it, it\u0027s useless.  Mark the slice methods with [[nodiscard]]\n(which is standard C++17) so that error would generate a warning.\n\nI guess that many functions could be marked as nodiscard, essentially\nfunction that is pure (doesn\u0027t have side-effects).  But this one seems\nparticularly easy to mis-use.\n\nChange-Id: Ib39a0a65a5728a3cfd68a02ae31635810baeaccb\nApproved-By: Tom Tromey \u003ctom@tromey.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ee3a3c58710c2723b86854c04b46b9b2751626f4",
      "old_mode": 33188,
      "old_path": "gdbsupport/array-view.h",
      "new_id": "4b519112e78f71eaa12940211d51ff8ee38c66c6",
      "new_mode": 33188,
      "new_path": "gdbsupport/array-view.h"
    }
  ]
}