tree 73e59f17c0e01f14c6978310cd5acac5dc934ffb
parent dbbfabb441556497f3ee9d89cf74bdc4a7a4c83c
author Simon Marchi <simon.marchi@efficios.com> 1698981549 -0400
committer Simon Marchi <simon.marchi@efficios.com> 1699036046 -0400

gdbsupport: mark array_view::slice with [[nodiscard]]

I (almost) had a bug where I did:

    buffer.slice (...)

but I meant:

    buffer = buffer.slice (...)

The first one does nothing, it creates a new array_view but without
using it, it's useless.  Mark the slice methods with [[nodiscard]]
(which is standard C++17) so that error would generate a warning.

I guess that many functions could be marked as nodiscard, essentially
function that is pure (doesn't have side-effects).  But this one seems
particularly easy to mis-use.

Change-Id: Ib39a0a65a5728a3cfd68a02ae31635810baeaccb
Approved-By: Tom Tromey <tom@tromey.com>