gdb: remove decref_target
The decref_target function is not really needed. Calling
target_ops::decref will just redirect to decref_target anyway, so why
not just rename decref_target to target_ops::decref?
That's what this commit does.
It's not exactly renaming to target_ops::decref, because the decref
functionality is handled by a policy class, so the new name is now
target_ops_ref_policy::decref.
There should be no user visible change after this commit.
diff --git a/gdb/target.c b/gdb/target.c
index b3fd234..417d384 100644
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -1166,7 +1166,7 @@
/* See target.h. */
void
-decref_target (target_ops *t)
+target_ops_ref_policy::decref (target_ops *t)
{
t->decref ();
if (t->refcount () == 0)
diff --git a/gdb/target.h b/gdb/target.h
index b9888f8..68446a39 100644
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -1337,9 +1337,6 @@
/* A unique pointer for target_ops. */
typedef std::unique_ptr<target_ops, target_ops_deleter> target_ops_up;
-/* Decref a target and close if, if there are no references left. */
-extern void decref_target (target_ops *t);
-
/* A policy class to interface gdb::ref_ptr with target_ops. */
struct target_ops_ref_policy
@@ -1349,10 +1346,9 @@
t->incref ();
}
- static void decref (target_ops *t)
- {
- decref_target (t);
- }
+ /* Decrement the reference count on T, and, if the reference count
+ reaches zero, close the target. */
+ static void decref (target_ops *t);
};
/* A gdb::ref_ptr pointer to a target_ops. */
