tree 385a0c6857a295638ca7d81a1440bb5b0e841c53
parent ebb83b77a74a4f31d7fba7e892599c4552aad137
author Tom Tromey <tromey@adacore.com> 1682623527 -0600
committer Tom Tromey <tromey@adacore.com> 1682701545 -0600

Do not change type in get_discrete_low_bound

get_discrete_low_bound has this code:

    /* Set unsigned indicator if warranted.  */
    if (low >= 0)
      type->set_is_unsigned (true);

It's bad to modify a type in a getter like this, so this patch removes
this code.  FWIW I looked and this code has been there since at least
1999 (it was in the initial sourceware import).

Types in general would benefit from const-ification, which would
probably reveal more code like this, but I haven't attempted that.

Regression tested on x86-64 Fedora 36.

Reviewed-by: Kevin Buettner <kevinb@redhat.com>