)]}'
{
  "commit": "b45b7407cdd07900ecc28a36710603edc96ade71",
  "tree": "51b0492155ad6ce5274736e1c3395292e02e0985",
  "parents": [
    "b1ac644a05245de73b84c23fa6a24eb039a727d7"
  ],
  "author": {
    "name": "Andrew Burgess",
    "email": "aburgess@redhat.com",
    "time": "Tue Feb 01 14:09:26 2022 +0000"
  },
  "committer": {
    "name": "Andrew Burgess",
    "email": "aburgess@redhat.com",
    "time": "Sun Apr 03 15:31:47 2022 +0100"
  },
  "message": "gdb/tui: relax restrictions on window max height and width\n\nThis commit removes some arbitrary adjustments made in\ntui_cmd_window::max_height, tui_win_info::max_height, and\ntui_win_info::max_width.\n\nThese member functions all subtract some constant from the theoretical\nmaximum height or width.  I\u0027ve looked back through the history a\nlittle and can see no real reason why these adjustments should be\nneeded, with these adjustments removed all the existing tui tests\nstill pass.\n\nHowever, retaining these restrictions causes some bugs, consider:\n\n  (gdb) tui new-layout hsrc {-horizontal src 1 cmd 1} 1\n\nWhen this layout is selected with current master, gdb will leave a 4\nline gap at the bottom of the terminal.\n\nThe problem is that the maximum height is restricted, for the cmd\nwindow, to 4 less than the terminal height.\n\nBy removing this restriction gdb is able to size the windows to the\ncomplete terminal height, and the layout is done correctly.\n\nThis 4 line restriction is also what prevents this layout from working\ncorrectly:\n\n  (gdb) tui new-layout conly cmd 1\n\nPreviously, this layout would present a cmd window only, but there\nwould be a 4 line gap at the bottom of the terminal.  This issue was\nmentioned in an earlier commit in this series (when a different bug\nwas fixed), but with this commit, the above layout now correctly fills\nthe terminal.  The associated test is updated.\n\nAfter removing the adjustment in tui_cmd_window::max_height, the\nimplementation is now the same as the implementation in the parent\nclass tui_win_info, so I\u0027ve completely removed the max_height call\nfrom tui_cmd_window.\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "883c7601be74c9c8a5ff01ca67527f92560681d9",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.tui/new-layout.exp",
      "new_id": "e662b1f0b18946dbc0eb2f8669b6e2ec6a515fe1",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.tui/new-layout.exp"
    },
    {
      "type": "modify",
      "old_id": "fa8af970b0aaeb91db94de7fd837e85c01d2aeb0",
      "old_mode": 33188,
      "old_path": "gdb/tui/tui-command.c",
      "new_id": "0f6c395f5679abcd66c0d1d8d0c3231e5f2f9f67",
      "new_mode": 33188,
      "new_path": "gdb/tui/tui-command.c"
    },
    {
      "type": "modify",
      "old_id": "06cc24f6faf8115b695fb553fc4ddf884547fbaf",
      "old_mode": 33188,
      "old_path": "gdb/tui/tui-command.h",
      "new_id": "6c354361d1d0ef4d7df212f10ac9c0bd76b4e4fb",
      "new_mode": 33188,
      "new_path": "gdb/tui/tui-command.h"
    },
    {
      "type": "modify",
      "old_id": "2ec618093b087afd14e3497e84fc02d2d06cb9ca",
      "old_mode": 33188,
      "old_path": "gdb/tui/tui-win.c",
      "new_id": "31b6606636ad5c24ab80aea4c22a68270d02f301",
      "new_mode": 33188,
      "new_path": "gdb/tui/tui-win.c"
    }
  ]
}