)]}'
{
  "commit": "b872057a63c53106e4bf6033a52d53b988f30dfd",
  "tree": "0178e5e9ae12af553f15c2e13cac0eb61e1cdafc",
  "parents": [
    "198f946ffe9fbfeeb187531e57cab6c3fd9d8b3d"
  ],
  "author": {
    "name": "Simon Marchi",
    "email": "simon.marchi@efficios.com",
    "time": "Fri Aug 26 15:38:26 2022 -0400"
  },
  "committer": {
    "name": "Simon Marchi",
    "email": "simon.marchi@polymtl.ca",
    "time": "Wed Sep 21 14:11:03 2022 -0400"
  },
  "message": "gdbsupport: convert FILEIO_* macros to an enum\n\nConverting from free-form macros to an enum gives a bit of type-safety.\nThis caught places where we would assign host error numbers to what\nshould contain a target fileio error number, for instance in\ntarget_fileio_pread.\n\nI added the FILEIO_SUCCESS enumerator, because\nremote.c:remote_hostio_parse_result initializes the remote_errno output\nvariable to 0.  It seems better to have an explicit enumerator than to\nassign a value for which there is no enumerator.  I considered\ninitializing this variable to FILEIO_EUNKNOWN instead, such that if the\nremote side replies with an error and omits the errno value, we\u0027ll get\nan errno that represents an error instead of 0 (which reprensents no\nerror).  But it\u0027s not clear what the consequences of that change would\nbe, so I prefer to err on the side of caution and just keep the existing\nbehavior (there is no intended change in behavior with this patch).\n\nNote that remote_hostio_parse_resul still reads blindly what the remote\nside sends as a target errno into this variable, so we can still end up\nwith a nonsensical value here.  It\u0027s not good, but out of the scope of\nthis patch.\n\nConvert host_to_fileio_error and fileio_errno_to_host to return / accept\na fileio_error instead of an int, and cascade the change in the whole\nchain that uses that.\n\nChange-Id: I454b0e3fcf0732447bc872252fa8e57d138b0e03\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "7631e274d82cf3fca9d88d13c49254173888fb16",
      "old_mode": 33188,
      "old_path": "gdb/gdb_bfd.c",
      "new_id": "14388159c525c315669d21262bad4819849be69b",
      "new_mode": 33188,
      "new_path": "gdb/gdb_bfd.c"
    },
    {
      "type": "modify",
      "old_id": "56ebd2a5549cadbb910446ba0b27b748328750be",
      "old_mode": 33188,
      "old_path": "gdb/inf-child.c",
      "new_id": "ca0af4c1b0327c06c057833be43ffb9dd3315281",
      "new_mode": 33188,
      "new_path": "gdb/inf-child.c"
    },
    {
      "type": "modify",
      "old_id": "ae5ace46f30e3d2a3b2705473e296c7d87f065f2",
      "old_mode": 33188,
      "old_path": "gdb/inf-child.h",
      "new_id": "167820380112d66f272150faa911823d18ffe9a1",
      "new_mode": 33188,
      "new_path": "gdb/inf-child.h"
    },
    {
      "type": "modify",
      "old_id": "e638e8ad04ee406b924de197bfd136973a5224d8",
      "old_mode": 33188,
      "old_path": "gdb/linux-nat.c",
      "new_id": "d4639766088c96f95fe13f07755361ed50cde20e",
      "new_mode": 33188,
      "new_path": "gdb/linux-nat.c"
    },
    {
      "type": "modify",
      "old_id": "38e253eff3643c849ff37b46d241f56142761eb3",
      "old_mode": 33188,
      "old_path": "gdb/linux-nat.h",
      "new_id": "a9b91a5e908b5dc1ab1b4571d10ee7b9b1b659b1",
      "new_mode": 33188,
      "new_path": "gdb/linux-nat.h"
    },
    {
      "type": "modify",
      "old_id": "85fad70b06a0facd8434990aa14f1a84214197b5",
      "old_mode": 33188,
      "old_path": "gdb/linux-tdep.c",
      "new_id": "adf518023bbe4617ed434bfacad4ca97106be571",
      "new_mode": 33188,
      "new_path": "gdb/linux-tdep.c"
    },
    {
      "type": "modify",
      "old_id": "5bae65472ed0489678444aa1ed100aa66e6cf223",
      "old_mode": 33188,
      "old_path": "gdb/remote.c",
      "new_id": "b57d26a70edb791f60d0f91f53bd1510c7e3dbf9",
      "new_mode": 33188,
      "new_path": "gdb/remote.c"
    },
    {
      "type": "modify",
      "old_id": "7b6e99197ac9ab7c82536c2efb8913e8a9116984",
      "old_mode": 33188,
      "old_path": "gdb/sparc64-tdep.c",
      "new_id": "5e696579f1fb2acde5f02424342b9abb542b6378",
      "new_mode": 33188,
      "new_path": "gdb/sparc64-tdep.c"
    },
    {
      "type": "modify",
      "old_id": "9d698afb09dca91042e17845e2a02832d3553cea",
      "old_mode": 33188,
      "old_path": "gdb/target.c",
      "new_id": "28560983625b14d66de0257fdc66967fa79dfd34",
      "new_mode": 33188,
      "new_path": "gdb/target.c"
    },
    {
      "type": "modify",
      "old_id": "7e52716a9e83303095b6e923bf823e1b418944d9",
      "old_mode": 33188,
      "old_path": "gdb/target.h",
      "new_id": "0b784278c4f82f2e91ab9d09dd43b389cefde77e",
      "new_mode": 33188,
      "new_path": "gdb/target.h"
    },
    {
      "type": "modify",
      "old_id": "b4feb8583ab041f9fc89a19781179f816ce1ae94",
      "old_mode": 33188,
      "old_path": "gdbsupport/fileio.cc",
      "new_id": "db7c1a7c488d6fcc9b7c598894bdc2a827cf8ff7",
      "new_mode": 33188,
      "new_path": "gdbsupport/fileio.cc"
    },
    {
      "type": "modify",
      "old_id": "9809c1623140aeeeeaaa962d275229212bbae504",
      "old_mode": 33188,
      "old_path": "gdbsupport/fileio.h",
      "new_id": "6a5297c64330957976192a14612e1402f335fa4c",
      "new_mode": 33188,
      "new_path": "gdbsupport/fileio.h"
    }
  ]
}