)]}'
{
  "commit": "bc5baa9f13ffb3fd4c39f1a779062bfb3a980cea",
  "tree": "a1f48c77e0649e279fac9a94aded93f1b53c3d9a",
  "parents": [
    "5f3fc928df037b21ee401d7115951b988a3ea571"
  ],
  "author": {
    "name": "Jan Beulich",
    "email": "jbeulich@suse.com",
    "time": "Thu May 19 12:43:10 2022 +0200"
  },
  "committer": {
    "name": "Jan Beulich",
    "email": "jbeulich@suse.com",
    "time": "Thu May 19 12:43:10 2022 +0200"
  },
  "message": "don\u0027t over-align file positions of PE executable sections\n\nWhen a sufficiently small alignment was specified via --file-alignment,\nindividual section alignment shouldn\u0027t affect placement within the file.\nThis involves first of all clearing D_PAGED for images when section and\nfile alignment together don\u0027t permit paging of the image. The involved\ncomparison against COFF_PAGE_SIZE in turn helped point out (through a\ncompiler warning) that \u0027page_size\u0027 should be of unsigned type (as in\nparticular FileAlignment is). This yet in turn pointed out a dubious\nerror condition (which is being deleted).\n\nFor the D_PAGED case I think the enforced file alignment may still be\ntoo high, but I\u0027m wary of changing that logic without knowing of\npossible corner cases.\n\nFurthermore file positions in PE should be independent of the alignment\nrecorded in section headers anyway. Otherwise there are e.g. anomalies\nfollowing commit 6f8f6017a0c4 (\"PR27567, Linking PE files adds alignment\nsection flags to executables\") in that linking would use information a\nsubsequent processing step (e.g. stripping) wouldn\u0027t have available\nanymore, and hence a binary could change in that 2nd step for no actual\nreason. (Similarly stripping a binary linked with a linker pre-dating\nthat commit would change the binary again when stripping it a 2nd time.)\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "dde8a649e433bd085220aff6109aa6e06f01b267",
      "old_mode": 33188,
      "old_path": "bfd/coffcode.h",
      "new_id": "0a6605191383c2eb7346a3b7e295a929bb8b4c27",
      "new_mode": 33188,
      "new_path": "bfd/coffcode.h"
    }
  ]
}
