)]}'
{
  "commit": "c6e7d403bb23ed7b3e85160def047fdb3482cfc0",
  "tree": "a0c10a2fae6dd759924bc360a6e9f3f52aa77054",
  "parents": [
    "c3466dee852578e8aab15662ee60ec184d7069e1"
  ],
  "author": {
    "name": "Andrew Burgess",
    "email": "aburgess@redhat.com",
    "time": "Fri May 10 14:41:03 2024 +0100"
  },
  "committer": {
    "name": "Andrew Burgess",
    "email": "aburgess@redhat.com",
    "time": "Mon Jun 24 12:13:20 2024 +0100"
  },
  "message": "gdb/doc: don\u0027t try to copy GDBvn.texi from the source tree\n\nThe build recipe for gdb.dvi and gdb.pdf contains instructions for\ncopying the GDBvn.texi file from the source tree into the build\ndirectory if the GDBvn.texi file doesn\u0027t already exist in the build\ndirectory.\n\nThe gdb.dvi and gdb.pdf targets also have a dependency on GDBvn.texi,\nand we have a recipe for building GDBvn.texi.\n\nWhat\u0027s happening here is this:\n\n  - In a git checkout of the source tree there is no GDBvn.texi in the\n    source tree, the GDBvn.texi dependency will trigger a rebuild of\n    GDBvn.texi, which is then used to build gdb.dvi and/or gdb.pdf.\n\n  - In a release tar file we do include a copy of GDBvn.texi.  This\n    file will appear to be up to date, and so no copy of GDBvn.texi is\n    created within the build directory.  Now when building gdb.dvi\n    and/or gdb.pdf we copy (or symlink) the version of GDBvn.texi from\n    the source tree into the build directory.\n\nHowever, copying GDBvn.texi from the source directory is completely\nunnecessary.  The gdb.dvi/gdb.pdf recipes both invoke texi2dvi and\npass \u0027-I $(srcdir)\u0027 as an argument, this means that texi2dvi will look\nin the $(srcdir) to find included files, including GDBvn.texi.\n\nAs such I believe we can remove the code that copies GDBvn.texi from\nthe source tree into the build tree.\n\nI\u0027ve tested with a release build; creating a release with:\n\n  ./src-release gdb\n\nThen in an empty directory, unpacking the resulting .tar file,\ncreating a parallel build directory and doing the usual configure,\nmake, and \u0027make install\u0027.\n\nHaving done this I can then \u0027touch gdb/doc/*.texinfo\u0027 in the unpacked\nsource tree, and do \u0027make -C gdb/doc pdf dvi\u0027 to rebuild all the pdf\nand dvi files, this works fine without having to either build or copy\nGDBvn.texi into the build directory.\n\nApproved-By: Tom Tromey \u003ctom@tromey.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "d9c13873a60d42f847c7051036de8861dfe7c0bb",
      "old_mode": 33188,
      "old_path": "gdb/doc/Makefile.in",
      "new_id": "1a0791d518fa26e6c851a4772a9eafda2bd62bae",
      "new_mode": 33188,
      "new_path": "gdb/doc/Makefile.in"
    }
  ]
}