LD: Guard `new_afile' result with assertions Calls to `new_afile' can in principle return a NULL pointer. However in `lookup_name' we dereference the pointer returned without validating it first. Since it's not supposed to be NULL there except where we have hit an internal consistency issue just add an assertion for meaningful output rather than just a segfault. For consistency update `cmdline_load_object_only_section' replacing a call to `abort' with the same assertion.
diff --git a/ld/ldlang.c b/ld/ldlang.c index 9f748f3..ef47151 100644 --- a/ld/ldlang.c +++ b/ld/ldlang.c
@@ -3025,6 +3025,7 @@ *stat_ptr->tail = rest; if (*tail == NULL) stat_ptr->tail = tail; + ASSERT (search != NULL); } /* If we have already added this file, or this file is not real @@ -11170,8 +11171,7 @@ lang_input_statement_type *entry = new_afile (name, lang_input_file_is_file_enum, NULL, NULL); - if (!entry) - abort (); + ASSERT (entry != NULL); ldfile_open_file (entry);