)]}' { "commit": "cce0ae568c7e30e0a7b8d1bd77f8c4b7d7b8ce7b", "tree": "14e4c08fb31df4412278a62a4bdf5f739be6d698", "parents": [ "aee9dcf8a836fe08e3d7f1b58a8b6dd2e16d9b68" ], "author": { "name": "Pedro Alves", "email": "pedro@palves.net", "time": "Wed May 18 13:22:02 2022 +0100" }, "committer": { "name": "Pedro Alves", "email": "pedro@palves.net", "time": "Wed May 25 13:44:12 2022 +0100" }, "message": "gdb: Fix DUPLICATE and PATH regressions throughout\n\nThe previous patch to add -prompt/-lbl to gdb_test introduced a\nregression: Before, you could specify an explicit empty message to\nindicate you didn\u0027t want to PASS, like so:\n\n gdb_test COMMAND PATTERN \"\"\n\nAfter said patch, gdb_test no longer distinguishes\nno-message-specified vs empty-message, so tests that previously would\nbe silent on PASS, now started emitting PASS messages based on\nCOMMAND. This in turn introduced a number of PATH/DUPLICATE\nviolations in the testsuite.\n\nThis commit fixes all the regressions I could see.\n\nThis patch uses the new -nopass feature introduced in the previous\ncommit, but tries to avoid it if possible. Most of the patch fixes\nDUPLICATE issues the usual way, of using with_test_prefix or explicit\nunique messages.\n\nSee previous commit\u0027s log for more info.\n\nIn addition to looking for DUPLICATEs, I also looked for cases where\nwe would now end up with an empty message in gdb.sum, due to a\ngdb_test being passed both no message and empty command. E.g., this\nin gdb.ada/bp_reset.exp:\n\n gdb_run_cmd\n gdb_test \"\" \"Breakpoint $decimal, foo\\\\.nested_sub \\\\(\\\\).*\"\n\nwas resulting in this in gdb.sum:\n\n PASS: gdb.ada/bp_reset.exp:\n\nI fixed such cases by passing an explicit message. We may want to\nmake such cases error out.\n\nTested on x86_64 GNU/Linux, native and native-extended-gdbserver. I\nsee zero PATH cases now. I get zero DUPLICATEs with native testing\nnow. I still see some DUPLICATEs with native-extended-gdbserver, but\nthose were preexisting, unrelated to the gdb_test change.\n\nChange-Id: I5375f23f073493e0672190a0ec2e847938a580b2\n", "tree_diff": [ { "type": "modify", "old_id": "12a4aa2c6ddfa4436b1f28c1c5e1298130f48653", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.ada/bp_reset.exp", "new_id": "f1e8b2e9473ae4f78fe5feaf9ef3e47e09d9e403", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.ada/bp_reset.exp" }, { "type": "modify", "old_id": "013d8ca9007d11c9f87b1e500849b6314865c0ff", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.ada/exec_changed.exp", "new_id": "52868f61c8938d909ccd5b8a89370b444fb8b753", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.ada/exec_changed.exp" }, { "type": "modify", "old_id": "f77d08a67cf3c4909b26293790e3dcecb669d9f5", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.ada/expr_delims.exp", "new_id": "c53d88fab3492d1fa86686624bb1a53e899d54a9", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.ada/expr_delims.exp" }, { "type": "modify", "old_id": "b1f8f8771563b83702fcab22e31b2d4346931717", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp", "new_id": "db1b3b32aa5bef3ac3c406ae094d1fabb13df965", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp" }, { "type": "modify", "old_id": "d69281c80038fa9cb5d4f2865e63c701ff679faf", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.base/break-probes.exp", "new_id": "51687c5ca68835e6166556e965b3299648cece41", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.base/break-probes.exp" }, { "type": "modify", "old_id": "2c939ada14ac1edf48a22537fe29a01b4f4d4697", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.base/break.exp", "new_id": "4421459154fe428d72f755b13fd9401cbb5c422a", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.base/break.exp" }, { "type": "modify", "old_id": "edb1c422c0e349558e66ae4a281e4ee461262aa5", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.base/checkpoint.exp", "new_id": "e81e4f44e485a691c935580446f2fbeaa9e6a393", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.base/checkpoint.exp" }, { "type": "modify", "old_id": "6abf2b8a2365c761ef4afbe8106729a370950caf", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.base/gdb-sigterm.exp", "new_id": "dd3bb731ab241969b1ce61a2e524530ca59be10f", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.base/gdb-sigterm.exp" }, { "type": "modify", "old_id": "39c9bc696ccf5e9c3de0a0a6c6b8c0313e947683", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.base/info-macros.exp", "new_id": "b2d75e49f4626cfdcf54c6d231ddf704d2d0fbd5", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.base/info-macros.exp" }, { "type": "modify", "old_id": "2364c74de96b646ef524112cc1b651cc845270f7", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.base/pie-execl.exp", "new_id": "f5dce989e28148d0ec16f2f5e42e4fbc69d1692d", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.base/pie-execl.exp" }, { "type": "modify", "old_id": "a2997be0cb8d22a624f29e91fd3a3be5d1bc3cd7", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.base/setvar.exp", "new_id": "576df2a066c4605649aa6ff62aa5e200376f1b7e", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.base/setvar.exp" }, { "type": "modify", "old_id": "effd398ef05c8594633207a84803d1ed49683075", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.base/sizeof.exp", "new_id": "7e86b2ac3e8fcb1e0757ab4d62197a9369c0f99b", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.base/sizeof.exp" }, { "type": "modify", "old_id": "2064e8d3894c4a01b64e28e42bbc10833c2a586e", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.base/style.exp", "new_id": "2242c5bf7430d8ae6c65340ddfb8d0312644555c", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.base/style.exp" }, { "type": "modify", "old_id": "6941fd95102ad79ba04ac7ebcfa7b230c12fb519", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.base/watchpoint-unaligned.exp", "new_id": "4dbd36929951863e989df813607ed3c99172f6f5", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.base/watchpoint-unaligned.exp" }, { "type": "modify", "old_id": "377d3f9ff43ad8da5cc9e3fa47279445b6355bdf", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.base/watchpoint.exp", "new_id": "97dee3a72b258ee11d35366891968a3bd4bf3651", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.base/watchpoint.exp" }, { "type": "modify", "old_id": "0a1a4abe69b5cf3ca58fba59a7cf686b08d7ddcf", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.cp/cpexprs.exp.tcl", "new_id": "b4ed3cda80e4823f3b040e3d11b320e9517a468a", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.cp/cpexprs.exp.tcl" }, { "type": "modify", "old_id": "cd3171e0d53eaa94270d0336d82fe95c54f0e161", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.cp/static-method.exp", "new_id": "efe56049239c208d6d15c06f4a07fc71d18c1d76", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.cp/static-method.exp" }, { "type": "modify", "old_id": "3b42a0fa8cc582ef881f9faff633d1c92c504002", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.reverse/insn-reverse.exp", "new_id": "c5437ecef6f1eb510266a83f69abe0db374eb2e2", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.reverse/insn-reverse.exp" }, { "type": "modify", "old_id": "348bec05e9a8c747717af4e37d8953b5a7267f2f", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.reverse/machinestate-precsave.exp", "new_id": "bafea4a30f6c020e1777e41db4b47b90414efb62", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.reverse/machinestate-precsave.exp" }, { "type": "modify", "old_id": "27916c7a8478db57f5200c3e5308b0710dd6dd1e", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.reverse/machinestate.exp", "new_id": "e33be3dbfedd539a2e95510a777cfbb2b07ac24f", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.reverse/machinestate.exp" }, { "type": "modify", "old_id": "8dc9af05c8efc57e0e7a56ebaf8cf6a8ad365cc6", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.threads/access-mem-running-thread-exit.exp", "new_id": "7932c0a82e61219ab224cce3394d156d48005fdc", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.threads/access-mem-running-thread-exit.exp" }, { "type": "modify", "old_id": "b4a255fe00e6a9f90d5b225e2a5536a596040cfe", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.threads/attach-into-signal.exp", "new_id": "11bfad4510ebcb80f0d998a98fce127330a8bf04", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.threads/attach-into-signal.exp" }, { "type": "modify", "old_id": "11ea3bccf4badfec43f470a45ce3dc361cf106b6", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.threads/sigstep-threads.exp", "new_id": "bad3ac72a98caca05e391d8393bd699217db1550", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.threads/sigstep-threads.exp" }, { "type": "modify", "old_id": "e686b93092626bb13ebd4e858ad2ebd809aab698", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.trace/actions.exp", "new_id": "c14fb27e3f6f9ed98055421423c69224e5a7bb48", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.trace/actions.exp" }, { "type": "modify", "old_id": "77d6a608287d8a190866ce2413d5539d4cb5cd68", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.trace/backtrace.exp", "new_id": "ec068b20d4ab12caf1cf72b2c8ce55228e86b2c1", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.trace/backtrace.exp" }, { "type": "modify", "old_id": "0f8b72172716e55f3abc75d9880f6f87b7370ce1", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.trace/collection.exp", "new_id": "c261b3c824d32d37df1a83aff1f22f367c500c05", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.trace/collection.exp" }, { "type": "modify", "old_id": "ad12c2fa8c962d8e1cd4cf5b5099f65b0f31b325", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.trace/infotrace.exp", "new_id": "1504fb36508a177962cf94b6f748a922b57860a1", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.trace/infotrace.exp" }, { "type": "modify", "old_id": "32fcecf4ad1d92b9aa9b73237f858717d0f33873", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.trace/passc-dyn.exp", "new_id": "747e4207dd0b0a8a86a6cc0abe64e57a35c2db44", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.trace/passc-dyn.exp" }, { "type": "modify", "old_id": "b538f4eba1dded5e4c4837ed67a865a55effa459", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.trace/report.exp", "new_id": "7b3678d29f347cc27466d16cd1f173abaca62eb4", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.trace/report.exp" }, { "type": "modify", "old_id": "c987ab14e4dfe94f11cb9fa28937713deb6400e2", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.trace/tfind.exp", "new_id": "57b7b2fad706fb61a60b1b98eef83e6ff9fd223e", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.trace/tfind.exp" }, { "type": "modify", "old_id": "f44036edf7a747f055a446c6948dd8c3dd0d7b15", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.trace/tspeed.exp", "new_id": "ba64176596bc9c8afe2ad4670e56a8987fb5dfe1", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.trace/tspeed.exp" }, { "type": "modify", "old_id": "ee8ba6b4b6670ba9b35e6398ebde3e00ee2584d2", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.trace/while-dyn.exp", "new_id": "c77bad73c2dc417181572f74a1e4be12a90a140b", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.trace/while-dyn.exp" }, { "type": "modify", "old_id": "0dcccab8d2d4eecb5a7133869de8e03f8641b67f", "old_mode": 33188, "old_path": "gdb/testsuite/gdb.trace/while-stepping.exp", "new_id": "77641b8a1307aaee676d4e15c0f62299f3116153", "new_mode": 33188, "new_path": "gdb/testsuite/gdb.trace/while-stepping.exp" }, { "type": "modify", "old_id": "30d3461c22687c0cc5ab530f2a9f6f3f1fbb3310", "old_mode": 33188, "old_path": "gdb/testsuite/lib/completion-support.exp", "new_id": "0c03d0f035e4f72af2df3accbdcdd9dc4c704f58", "new_mode": 33188, "new_path": "gdb/testsuite/lib/completion-support.exp" }, { "type": "modify", "old_id": "1ba7a872cc30df8cc337250941b01c757d37f354", "old_mode": 33188, "old_path": "gdb/testsuite/lib/gdb-guile.exp", "new_id": "b42409d96b470d9b5f50b42ea0c00f5414f4046c", "new_mode": 33188, "new_path": "gdb/testsuite/lib/gdb-guile.exp" }, { "type": "modify", "old_id": "960c0eb2313a59bc7297ff2b75d210db0351dd0a", "old_mode": 33188, "old_path": "gdb/testsuite/lib/gdb.exp", "new_id": "b04fbb89e4e4b886168e23484abe0372b20e2b1d", "new_mode": 33188, "new_path": "gdb/testsuite/lib/gdb.exp" }, { "type": "modify", "old_id": "92fccb596f7e89e3999aae5c06e97d5d917c2222", "old_mode": 33188, "old_path": "gdb/testsuite/lib/range-stepping-support.exp", "new_id": "5bef91d19b838bc88a05ca268f5037129f7cdb2c", "new_mode": 33188, "new_path": "gdb/testsuite/lib/range-stepping-support.exp" }, { "type": "modify", "old_id": "32969858608a322edc7343459838a240aa3930cb", "old_mode": 33188, "old_path": "gdb/testsuite/lib/trace-support.exp", "new_id": "ccad22ecd995e7d943c76c1b8ba80877a84dcea4", "new_mode": 33188, "new_path": "gdb/testsuite/lib/trace-support.exp" } ] }