)]}'
{
  "commit": "d8a2c719dace17e329d329dc2e38fbddb95fef11",
  "tree": "3f358a1ab409142a4a5d8f14807dfc060f01fa38",
  "parents": [
    "dcf4c484539a9ab5fdd0c5ddf43617986480b9bc"
  ],
  "author": {
    "name": "Andrew Burgess",
    "email": "aburgess@redhat.com",
    "time": "Sun Nov 10 14:34:58 2024 +0000"
  },
  "committer": {
    "name": "Andrew Burgess",
    "email": "aburgess@redhat.com",
    "time": "Thu Nov 14 19:34:43 2024 +0000"
  },
  "message": "gdb/python: remove some additional PyObject_IsTrue calls\n\nAfter the previous commit I audited all our uses of PyObject_IsTrue\nlooking for places where we were missing an error check.  I did find\nsome that are missing error checks in places where we really should\nhave error checks, and I\u0027ll fix those in later commits.\n\nThis commit however, focuses on those locations where PyObject_IsTrue\nis called, there is no error check, and the error check isn\u0027t really\nnecessary because we already know that the object we are dealing with\nis of type PyBool_Type.\n\nInline with the previous commit, in these cases I have removed the\nPyObject_IsTrue call, and replaced it with a comparison against\nPy_True.  In one location where it is not obvious that the object we\nhave is PyBool_Type I\u0027ve added an assert, but in the other cases the\ncomparison to Py_True immediately follows a PyBool_Check call, so an\nassert would be redundant.\n\nI\u0027ve added a test for the gdb.Value.format_string styling argument\nbeing passed a non-bool value as this wasn\u0027t previously being tested,\nthough this new test will pass before and after this commit.\n\nThere should be no functional change after this commit.\n\nApproved-By: Tom Tromey \u003ctom@tromey.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "7b64436d8bf3ba82037972b45c596a16045bc09a",
      "old_mode": 33188,
      "old_path": "gdb/python/py-disasm.c",
      "new_id": "58e2efe0819ab0c955a8b8fda0c50a83fa183616",
      "new_mode": 33188,
      "new_path": "gdb/python/py-disasm.c"
    },
    {
      "type": "modify",
      "old_id": "119bf9f76d767018a14d0f42a05cb8288816ec64",
      "old_mode": 33188,
      "old_path": "gdb/python/py-value.c",
      "new_id": "eef3841924fabf31d5b203c7227e020c3e27a0a1",
      "new_mode": 33188,
      "new_path": "gdb/python/py-value.c"
    },
    {
      "type": "modify",
      "old_id": "d0349c546ad5099c9368f0a923ba90f24f729fd7",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.python/py-format-string.exp",
      "new_id": "9102391b0be7ec6019e1056e5983c993b4913110",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.python/py-format-string.exp"
    }
  ]
}