tree 04e2d5d13c4f771bb1d717c322aa48f76b4e3376
parent 5abbfa982215a5bcd2bf2c0b92cbb005464dc927
author Tom Tromey <tromey@adacore.com> 1673627274 -0700
committer Tom Tromey <tromey@adacore.com> 1675869612 -0700

Remove most calls to fixup_symbol_section

Nearly every call to fixup_symbol_section in gdb is incorrect, and if
any such call has an effect, it's purely by happenstance.

fixup_section has a long comment explaining that the call should only
be made before runtime section offsets are applied.  And, the loop in
this code (the fallback loop -- the minsym lookup code is "ok") is
careful to remove these offsets before comparing addresses.

However, aside from a single call in dwarf2/read.c, every call in gdb
is actually done after section offsets have been applied.  So, these
calls are incorrect.

Now, these calls could be made when the symbol is created.  I
considered this approach, but I reasoned that the code has been this
way for many years, seemingly without ill effect.  So, instead I chose
to simply remove the offending calls.