commit dde238e063376f96d52ff27f11b31a447ddbdfea
author Tom Tromey <tom@tromey.com> Sat Dec 11 15:10:14 2021 -0700
committer Tom Tromey <tom@tromey.com> Mon Dec 20 08:49:27 2021 -0700
tree 12d55ab85c592669dd02d14817f247bea49dc718
parent db956d66c94de1bc1ff9ac1c38350f14e81c11f6

Make n_spaces return a const char *

n_spaces keeps the spaces in a static buffer.  If a caller overwrites
these, it may give an incorrect result to a subsequent caller.  So,
make the return type const to help avoid this outcome.

gdb/utils.c

diff --git a/gdb/utils.c b/gdb/utils.c
index e27a881..ea0f65c 100644
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -2303,7 +2303,7 @@ puts_unfiltered (const char *string)
 
 /* Return a pointer to N spaces and a null.  The pointer is good
    until the next call to here.  */
-char *
+const char *
 n_spaces (int n)
 {
   char *t;

gdb/utils.h

diff --git a/gdb/utils.h b/gdb/utils.h
index 6f3a702..f6fd32f 100644
--- a/gdb/utils.h
+++ b/gdb/utils.h
@@ -473,7 +473,7 @@ extern void print_spaces (int, struct ui_file *);
 
 extern void print_spaces_filtered (int, struct ui_file *);
 
-extern char *n_spaces (int);
+extern const char *n_spaces (int);
 
 extern void fputstr_filtered (const char *str, int quotr,
 			      struct ui_file * stream);