)]}'
{
  "commit": "e01493b7cb86ef874afb42efb1720ab1fbedfb6f",
  "tree": "2dfc490ee3e25d020b3c51a32d9eece8ddc4501b",
  "parents": [
    "de69cec0c53f1ef5cb242bfc969723b7dba4defb"
  ],
  "author": {
    "name": "Enze Li",
    "email": "enze.li@hotmail.com",
    "time": "Sun Jul 24 11:20:46 2022 +0800"
  },
  "committer": {
    "name": "Enze Li",
    "email": "enze.li@hotmail.com",
    "time": "Tue Jul 26 20:34:30 2022 +0800"
  },
  "message": "gdb/hurd: pass memory_tagged as false to find_memory_region_ftype\n\nI tried building GDB on GNU/Hurd, and ran into this error:\n\n  CXX    gnu-nat.o\ngnu-nat.c: In member function ‘virtual int gnu_nat_target::find_memory_regions(find_memory_region_ftype, void*)’:\ngnu-nat.c:2620:21: error: too few arguments to function\n 2620 |             (*func) (last_region_address,\n      |             ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~\n 2621 |                      last_region_end - last_region_address,\n      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n 2622 |                      last_protection \u0026 VM_PROT_READ,\n      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n 2623 |                      last_protection \u0026 VM_PROT_WRITE,\n      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n 2624 |                      last_protection \u0026 VM_PROT_EXECUTE,\n      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n 2625 |                      1, /* MODIFIED is unknown, pass it as true.  */\n      |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n 2626 |                      data);\n      |                      ~~~~~\ngnu-nat.c:2635:13: error: too few arguments to function\n 2635 |     (*func) (last_region_address, last_region_end - last_region_address,\n      |     ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n 2636 |              last_protection \u0026 VM_PROT_READ,\n      |              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n 2637 |              last_protection \u0026 VM_PROT_WRITE,\n      |              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n 2638 |              last_protection \u0026 VM_PROT_EXECUTE,\n      |              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n 2639 |              1, /* MODIFIED is unknown, pass it as true.  */\n      |              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n 2640 |              data);\n      |              ~~~~~\nmake[2]: *** [Makefile:1926: gnu-nat.o] Error 1\n\nThis is because in this commit:\n\n  commit 68cffbbd4406b4efe1aa6e18460b1d7ca02549f1\n  Date:   Thu Mar 31 11:42:35 2022 +0100\n\n      [AArch64] MTE corefile support\n\nAdded a new argument to find_memory_region_ftype, but did not pass it to\nthe function in gnu-nat.c.  Fix this by passing memory_tagged as false.\n\nAs Luis pointed out, similar bugs may also appear on FreeBSD and NetBSD,\nand I have reproduced them on both systems.  This patch fixes them\nincidentally.\n\nTested by rebuilding on GNU/Hurd, FreeBSD/amd64 and NetBSD/amd64.\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "398f1c18b3325611ddc01dfd6a121cad9a5fb352",
      "old_mode": 33188,
      "old_path": "gdb/fbsd-nat.c",
      "new_id": "a4ca4a53415b8da0f52242c8e0d17c46d8afe5e7",
      "new_mode": 33188,
      "new_path": "gdb/fbsd-nat.c"
    },
    {
      "type": "modify",
      "old_id": "72314824278584cfcfcc3abb3560da437a781725",
      "old_mode": 33188,
      "old_path": "gdb/gnu-nat.c",
      "new_id": "5dd4d148c765c24c9be787d59ca57b8351686ca1",
      "new_mode": 33188,
      "new_path": "gdb/gnu-nat.c"
    },
    {
      "type": "modify",
      "old_id": "8a4a43270d6682b543374f529f5687d69be5ee50",
      "old_mode": 33188,
      "old_path": "gdb/netbsd-nat.c",
      "new_id": "bbadd86582397080dab034940d6d0d53bbb6e704",
      "new_mode": 33188,
      "new_path": "gdb/netbsd-nat.c"
    }
  ]
}