)]}'
{
  "commit": "e2f620135d92f7cd670af4e524fffec7ac307666",
  "tree": "806c567979eb14373f6bd639bc9600e9a54b0818",
  "parents": [
    "c5a5f322a4e50fbfb303874671ab541757a941cf"
  ],
  "author": {
    "name": "Andrew Burgess",
    "email": "aburgess@redhat.com",
    "time": "Thu Mar 30 13:26:25 2023 +0100"
  },
  "committer": {
    "name": "Andrew Burgess",
    "email": "aburgess@redhat.com",
    "time": "Thu Apr 27 13:56:37 2023 +0100"
  },
  "message": "gdb/testsuite: change newline patterns used in gdb_test\n\nThis commit makes two changes to how we match newline characters in\nthe gdb_test proc.\n\nFirst, for the newline pattern between the command output and the\nprompt, I propose changing from \u0027[\\r\\n]+\u0027 to an explicit \u0027\\r\\n\u0027.\n\nThe old pattern would spot multiple newlines, and so there are a few\nplaces where, as part of this commit, I\u0027ve needed to add an extra\ntrailing \u0027\\r\\n\u0027 to the pattern in the main test file, where GDB\u0027s\noutput actually includes a blank line.\n\nBut I think this is a good thing.  If a command produces a blank line\nthen we should be checking for it, the current gdb_test doesn\u0027t do\nthat.  But also, with the current gdb_test, if a blank line suddenly\nappears in the output, this is going to be silently ignored, and I\nthink this is wrong, the test should fail in that case.\n\nAdditionally, the existing pattern will happily match a partial\nnewline.  There are a strangely large number of tests that end with a\nrandom \u0027.\u0027 character.  Not matching a literal period, but matching any\nsingle character, this is then matching half of the trailing newline\nsequence, while the \\[\\r\\n\\]+ in gdb_test is matching the other half\nof the sequence.  I can think of no reason why this would be\nintentional, I suspect that the expected output at one time included a\nperiod, which has since been remove, but I haven\u0027t bothered to check\non this.  In this commit I\u0027ve removed all these unneeded trailing \u0027.\u0027\ncharacters.\n\nThe basic rule of gdb_test after this is that the expected pattern\nneeds to match everything up to, but not including the newline\nsequence immediately before the GDB prompt.  This is generally how the\nproc is used anyway, so in almost all cases, this commit represents no\nsignificant change.\n\nSecond, while I was cleaning up newline matching in gdb_test, I\u0027ve\nalso removed the \u0027[\\r\\n]*\u0027 that was added to the start of the pattern\npassed to gdb_test_multiple.\n\nThe addition of this pattern adds no value.  If the user pattern\nmatches at the start of a line then this would match against the\nnewline sequence.  But, due to the \u0027*\u0027, if the user pattern doesn\u0027t\nmatch at the start of a line then this group doesn\u0027t care, it\u0027ll\nhappily match nothing.\n\nAs such, there\u0027s no value to it, it just adds more complexity for no\ngain, so I\u0027m removing it.  No tests will need updating as a\nconsequence of this part of the patch.\n\nReviewed-By: Tom Tromey \u003ctom@tromey.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ceb0c8594a7ce85f7ee5563c120503dc7b509489",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.ada/varsize_limit.exp",
      "new_id": "64f2e3fa2896989d507e309cec35fd1d0b3c1cbc",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.ada/varsize_limit.exp"
    },
    {
      "type": "modify",
      "old_id": "63db4c56d574f000d8aa11cd765340fd8c223b6c",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.base/call-rt-st.exp",
      "new_id": "d9c9abe604f57b7e01b0bc70650a272846a5a1f8",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/call-rt-st.exp"
    },
    {
      "type": "modify",
      "old_id": "1387e171882e63e348f33ec7ba88721f9c45eab6",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.base/charset.exp",
      "new_id": "34b4c7134b9a83dc79a778939a1bda2f47d8c787",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/charset.exp"
    },
    {
      "type": "modify",
      "old_id": "7e73db0576a729fd277d79c56f2a9df8cb064ebc",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.base/default.exp",
      "new_id": "3c5e8b7598d8b6d9b1dfb87af4e4bf8657f931e1",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/default.exp"
    },
    {
      "type": "modify",
      "old_id": "79ef4d894e8a34c190d4b9bcfd589e6f719e2fd4",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.base/display.exp",
      "new_id": "6978aedff43f42dc2280938286b934dd40b22486",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/display.exp"
    },
    {
      "type": "modify",
      "old_id": "df5dab056c219ca2e79320057ba651b3f042dbd1",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.base/foll-fork.exp",
      "new_id": "b0ba156e3dba05f5c1a654bb451b17eb3c2c32e8",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/foll-fork.exp"
    },
    {
      "type": "modify",
      "old_id": "38eb35f1df8710049c61ea1e3882a8b034b8d9c5",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.base/info-macros.exp",
      "new_id": "fd4a99c9794979d28625545ee52bb0c539bfb9c4",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/info-macros.exp"
    },
    {
      "type": "modify",
      "old_id": "e7ebd3804cb30994e7a978fe257e14ca76b6c9c2",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.base/pc-fp.exp",
      "new_id": "466a6d62395dc43632a988b14118ef5f34c4c9de",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/pc-fp.exp"
    },
    {
      "type": "modify",
      "old_id": "be54fb1ce08628e4cfa357fe6fcbc601bd9cabe3",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.base/pending.exp",
      "new_id": "d7d3735000aa7622766c8cdc83cd4456cb288cc3",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/pending.exp"
    },
    {
      "type": "modify",
      "old_id": "f2cf0b149964252447d2452dfc01118b619b3804",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.base/rtld-step.exp",
      "new_id": "9a6c76d191acbb0b89779bcc1f67a01808f8edfc",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/rtld-step.exp"
    },
    {
      "type": "modify",
      "old_id": "86821ca1db083dfff848c2eff27648ff6f458bf5",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.base/setshow.exp",
      "new_id": "8c160aa560ee9c2e08a0522bb6612fccbfd34c7b",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/setshow.exp"
    },
    {
      "type": "modify",
      "old_id": "e1a1765ec2e95dd067430cc9ac433b544fb9387b",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.base/until.exp",
      "new_id": "4a1a07dae7adf53c2852b66ddf7f4e580ac4832f",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/until.exp"
    },
    {
      "type": "modify",
      "old_id": "ce2aee2ac183d3bedfbf51cbe4f65cf536ba6620",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.base/watch-bitfields.exp",
      "new_id": "95573caa7dd1a352c1c06c777a9cf24d0b13c916",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/watch-bitfields.exp"
    },
    {
      "type": "modify",
      "old_id": "2ab0133cfe641c82575eaab66a61e7e48846b895",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.base/wrong_frame_bt_full.exp",
      "new_id": "5321cdcbac65ae8c9822300549fa1e60a3a0a3c0",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/wrong_frame_bt_full.exp"
    },
    {
      "type": "modify",
      "old_id": "e632ba56cf9cf378dccaaa28053aa0bf253b5260",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.btrace/buffer-size.exp",
      "new_id": "616c7f170e5fdff15b3afe4ddedcc651600f54ab",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.btrace/buffer-size.exp"
    },
    {
      "type": "modify",
      "old_id": "e71e48fc0ca9739e3e0998c4b2d629c2d2f82f42",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.btrace/function_call_history.exp",
      "new_id": "de4cdf9783d99c9c9825786f78db3a600eaccddc",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.btrace/function_call_history.exp"
    },
    {
      "type": "modify",
      "old_id": "35b43d6843408d904532650cfd73055e3da4d639",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.btrace/instruction_history.exp",
      "new_id": "f6c1fae720fe6fbbc527b35296e13bceed6b2030",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.btrace/instruction_history.exp"
    },
    {
      "type": "modify",
      "old_id": "240e18f67d69d07bfa626b7bb4775f5ce95bdcec",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.btrace/record_goto.exp",
      "new_id": "1817ac07f5129615faa96b21ffd0376ba178c494",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.btrace/record_goto.exp"
    },
    {
      "type": "modify",
      "old_id": "050bd98cf56746961ed224f84b24efa6209112bf",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.cp/incomplete-type-overload.exp",
      "new_id": "01201ecd3964d1ecefab0f0ad1e076d787bdb9e0",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.cp/incomplete-type-overload.exp"
    },
    {
      "type": "modify",
      "old_id": "59dccfbb3bdfa4715c34e6cfe2f20ac98f807e3e",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.cp/maint.exp",
      "new_id": "36a48e5637da0ce5b86938de68881f019ad1966d",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.cp/maint.exp"
    },
    {
      "type": "modify",
      "old_id": "62e45f50d0eec54255099eeda3e678cd44be0342",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.cp/ovldbreak.exp",
      "new_id": "fd8268a5791c3376d1f652a6ecda329671cd5a3e",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.cp/ovldbreak.exp"
    },
    {
      "type": "modify",
      "old_id": "f04a441c54d858dfddbbe8e5cf83748955d7d5b4",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.cp/userdef.exp",
      "new_id": "ac453179da243c4fde99979b78ec058a68cfd0ad",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.cp/userdef.exp"
    },
    {
      "type": "modify",
      "old_id": "445befddf285e3c03de06b121b562db2efc8c90a",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.cp/virtfunc.exp",
      "new_id": "908c969741b65740005ad7f956fd69114403cda0",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.cp/virtfunc.exp"
    },
    {
      "type": "modify",
      "old_id": "a9e656ddfc0df92f173e182f63f9ecb1eb2e5a33",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.guile/scm-breakpoint.exp",
      "new_id": "baa80b4c37c5949735e8fc6dc5044fedf53a871b",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.guile/scm-breakpoint.exp"
    },
    {
      "type": "modify",
      "old_id": "25a9780a4d5fb5fa87620efbf36eee032428b6b2",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.guile/scm-cmd.exp",
      "new_id": "afcb17c20962c2dc18c12d132a604feaee099968",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.guile/scm-cmd.exp"
    },
    {
      "type": "modify",
      "old_id": "4c1fb052b5cd3cf43ea85a1619435f9d0013ea46",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.opt/inline-break.exp",
      "new_id": "9446ef5b6b474a821b37ca4e18ba8f5545e22de4",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.opt/inline-break.exp"
    },
    {
      "type": "modify",
      "old_id": "ab81b7ade8575e1935b2f9be367cfd88cf80425e",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.python/py-breakpoint.exp",
      "new_id": "76094c95d107f9324ee67428b50b09a7d874d925",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.python/py-breakpoint.exp"
    },
    {
      "type": "modify",
      "old_id": "fd53806e467366ec98e665904d06915eb8084d96",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.reverse/machinestate-precsave.exp",
      "new_id": "5c9538075840b31b39b9655496ad9a41aba3be9c",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.reverse/machinestate-precsave.exp"
    },
    {
      "type": "modify",
      "old_id": "68412b47d3bd0bf725460ada5a8d169b7def427a",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.reverse/machinestate.exp",
      "new_id": "60d8f33a0226da9e440abef77f206365f1c418e3",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.reverse/machinestate.exp"
    },
    {
      "type": "modify",
      "old_id": "e7ee9385919e630c8a4a1634d8f4ec593eb12789",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.stabs/exclfwd.exp",
      "new_id": "a6e6ff860462ac15635c091ae26c00da6f05f5ee",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.stabs/exclfwd.exp"
    },
    {
      "type": "modify",
      "old_id": "0186a38fed9c34f901106e2beca9c1a4307c7fe9",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.threads/foll-fork-other-thread.exp",
      "new_id": "73bea594e158cf178ec308cbac491e43980d6696",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.threads/foll-fork-other-thread.exp"
    },
    {
      "type": "modify",
      "old_id": "97d67b7a217e17f68365d4e53d43bd66be00a86b",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.threads/gcore-thread.exp",
      "new_id": "d606e19deb14b1d1c92c299e9dc185906f913199",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.threads/gcore-thread.exp"
    },
    {
      "type": "modify",
      "old_id": "ffc3250577f182954f197188f1b3250c63a70b42",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.trace/actions.exp",
      "new_id": "2a2158886d8dd2711b9c7c41434810e708c8743b",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.trace/actions.exp"
    },
    {
      "type": "modify",
      "old_id": "a849d96f432a752b33181b6b0284fb2547c35b3d",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.trace/deltrace.exp",
      "new_id": "2142dc99f503e667707d4a8ffa12c0d3ef1b49b8",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.trace/deltrace.exp"
    },
    {
      "type": "modify",
      "old_id": "83660bed7a5c494b0ccbc2c9a6d0335b62955b51",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.trace/infotrace.exp",
      "new_id": "97ef66b8df2a14762738500f491b7791f6863d08",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.trace/infotrace.exp"
    },
    {
      "type": "modify",
      "old_id": "f2b70c3f3ade58ec9d2654604a8408ab8f6f0881",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.trace/passcount.exp",
      "new_id": "e09849303f3e4b4d85bc30b481e753d823d4681e",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.trace/passcount.exp"
    },
    {
      "type": "modify",
      "old_id": "3fed8dad2ec61ad3bbc31d1060aa5609476a09a5",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.trace/tracecmd.exp",
      "new_id": "9d0310188f2476e0c75d81771a75f45b832fa306",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.trace/tracecmd.exp"
    },
    {
      "type": "modify",
      "old_id": "995b5a083a414b16f299a5b4e0cdfc8184182e12",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.trace/while-stepping.exp",
      "new_id": "21cc2ee8298fc73fd8db52570f63d0e1c3f95b62",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.trace/while-stepping.exp"
    },
    {
      "type": "modify",
      "old_id": "5dc79452a4b34d838166bcaf802d45973076563f",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/lib/gdb.exp",
      "new_id": "5fd084bf54ac8de913b7d337f16e2d575ab80ad8",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/lib/gdb.exp"
    }
  ]
}