)]}'
{
  "commit": "f20ff8373775e236e63e45ca2d4683d5f69882a7",
  "tree": "8fd8a6c604228f1f11b1bcb5fec5ea423e08a042",
  "parents": [
    "298e9637305ee85f630638ba723494fb208eabad"
  ],
  "author": {
    "name": "Tom de Vries",
    "email": "tdevries@suse.de",
    "time": "Wed Feb 19 22:33:42 2020 +0100"
  },
  "committer": {
    "name": "Tom de Vries",
    "email": "tdevries@suse.de",
    "time": "Wed Feb 19 22:33:42 2020 +0100"
  },
  "message": "[gdb/testsuite] Fix funcall_ref.exp xpass\n\nWhen running gdb.ada/funcall_ref.exp I run into two XPASSes:\n...\n(gdb) p get (\"Hello world!\")^M\n$1 \u003d (n \u003d\u003e 12, s \u003d\u003e \"Hello world!\")^M\n(gdb) XPASS: gdb.ada/funcall_ref.exp: p get (\"Hello world!\")\nptype get (\"Hello world!\")^M\ntype \u003d \u003cref\u003e record^M\n    n: natural;^M\n    s: access array (1 .. n) of character;^M\nend record^M\n(gdb) XPASS: gdb.ada/funcall_ref.exp: ptype get (\"Hello world!\")\n...\n\nThe xfails are documented in funcall_ref.exp:\n...\n # Currently, GCC describes such functions as returning pointers (instead of\n # references).\n setup_xfail *-*-*\n...\n\nUsing gnatmake 4.8, we can reproduce the XFAILs:\n...\n(gdb) p get (\"Hello world!\")^M\n$1 \u003d (access foo.bar) 0x6147b0 \u003csystem.secondary_stack.chunk+48\u003e^M\n(gdb) XFAIL: gdb.ada/funcall_ref.exp: p get (\"Hello world!\")\nptype get (\"Hello world!\")^M\ntype \u003d access record^M\n    n: natural;^M\n    s: access array (1 .. n) of character;^M\nend record^M\n(gdb) XFAIL: gdb.ada/funcall_ref.exp: ptype get (\"Hello world!\")\n...\n\nFix the XPASSes by:\n- removing the xfail setup\n- switching the order of the two tests\n- detecting the \"access record\" type and declaring the first test unsupported,\n  and skipping the second test\n\nTested on x86_64-linux, both with gnatmake 4.8.5 and gnatmake 7.5.0.\n\ngdb/testsuite/ChangeLog:\n\n2020-02-19  Tom de Vries  \u003ctdevries@suse.de\u003e\n\n\t* gdb.ada/funcall_ref.exp: Replace xfail setup by unsupported check.\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "0dff20d38357e2fdba80eb695d4486dde185462a",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/ChangeLog",
      "new_id": "bfa1afc7f0f95595724c477f4af11b6b7fa780db",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/ChangeLog"
    },
    {
      "type": "modify",
      "old_id": "2992e56a2094cbdf6faa71914dafbce1439f6758",
      "old_mode": 33188,
      "old_path": "gdb/testsuite/gdb.ada/funcall_ref.exp",
      "new_id": "02664f6ad3296cc385ff4fc563884588f78f91ec",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.ada/funcall_ref.exp"
    }
  ]
}
