)]}'
{
  "commit": "ff7e8fe777f8a6be213a01c99d2c6bb6a08532bf",
  "tree": "c121dcae1e8d33a3a385d346212e015c04d88354",
  "parents": [
    "f4e41bbd789ebdf105dd4f95b44e7ea1cdd8872c"
  ],
  "author": {
    "name": "Maciej W. Rozycki",
    "email": "macro@orcam.me.uk",
    "time": "Sun Nov 15 10:53:38 2026 +0000"
  },
  "committer": {
    "name": "Maciej W. Rozycki",
    "email": "macro@orcam.me.uk",
    "time": "Sun Nov 15 10:53:38 2026 +0000"
  },
  "message": "MIPS/GAS: Reinstate INSN_MULT interlock optimization\n\nOnly integer division instructions in the Toshiba TX39 processor are\nunsafe to be preceded by a HI and/or LO register read operation as the\nfirst or second instruction ahead.\n\nThis optimization used to be there in GAS, but was silently dropped with\ncommit 71400594f26d (\"Rework MIPS nop-insertion code, add -mfix-vr4130\"),\n\u003chttps://inbox.sourceware.org/binutils/wvnfyz6ch5y.fsf_-_@talisman.cambridge.redhat.com/\u003e,\ncausing unnecesary NOPs to be emitted ahead of multiplication opcodes.\nThe INSN_MULT flag used in the opcode table to mark eligible entries was\nleft behind, unused, but the GAS parts were removed.\n\nReinstate the missing parts, observing that unlike with other opcode\nflags INSN_MULT uses negative logic and marks entries that don\u0027t imply\nrather than do a data dependency.  Therefore INSN_MULT needs to be\ncleared rather than set when no previous instruction is available in\n`insns_between\u0027.\n\nOtherwise filler NOPs would fail to be produced for DIV, DIVU, MULO,\nMULOU macros preceded by an instruction that reads the HI and/or LO\nregister, showing as R3900 test regressions:\n\nFAIL: MIPS div (r3900)\nFAIL: MIPS div with traps (r3900)\nFAIL: MIPS mul (r3900)\nFAIL: MIPS mul with traps (r3900)\n\nThis peculiarity will be removed with the next change.\n\nAdjust the testsuite for the optimization now re-enabled.\n\nUpdate the comment in `insns_between\u0027 saying that this optimization does\nnot apply for most targets since this has long become not the case.\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "4fe12161aaeabf53035114f936f8856281d28614",
      "old_mode": 33188,
      "old_path": "gas/config/tc-mips.c",
      "new_id": "b9e152c81b7231ac662ae06238107ced08fedebd",
      "new_mode": 33188,
      "new_path": "gas/config/tc-mips.c"
    },
    {
      "type": "modify",
      "old_id": "e9b8b2e7a6ea5f6368df729b6355167ce3b0bcdd",
      "old_mode": 33188,
      "old_path": "gas/testsuite/gas/mips/allegrex@mul-trap.d",
      "new_id": "8599e8c0c0e3f7e6e3a27a0c0f98533389fb8d13",
      "new_mode": 33188,
      "new_path": "gas/testsuite/gas/mips/allegrex@mul-trap.d"
    },
    {
      "type": "modify",
      "old_id": "7479f0b7c703606b0bd9a72b010831d1e1a26b13",
      "old_mode": 33188,
      "old_path": "gas/testsuite/gas/mips/allegrex@mul.d",
      "new_id": "eed8bfef51c8cff5d569fac696e28022c5ec1a46",
      "new_mode": 33188,
      "new_path": "gas/testsuite/gas/mips/allegrex@mul.d"
    },
    {
      "type": "modify",
      "old_id": "9990e362e4884533a3119786a50c202c0485d99b",
      "old_mode": 33188,
      "old_path": "gas/testsuite/gas/mips/r10000@mul.d",
      "new_id": "eed8bfef51c8cff5d569fac696e28022c5ec1a46",
      "new_mode": 33188,
      "new_path": "gas/testsuite/gas/mips/r10000@mul.d"
    },
    {
      "type": "modify",
      "old_id": "597c1a9fa43416c0c1fcce52d698398979e14c5d",
      "old_mode": 33188,
      "old_path": "gas/testsuite/gas/mips/r3900@mul-trap.d",
      "new_id": "8599e8c0c0e3f7e6e3a27a0c0f98533389fb8d13",
      "new_mode": 33188,
      "new_path": "gas/testsuite/gas/mips/r3900@mul-trap.d"
    },
    {
      "type": "modify",
      "old_id": "fd1ce2f53465de0b134f417417ffe72fd1f9f067",
      "old_mode": 33188,
      "old_path": "gas/testsuite/gas/mips/r3900@mul.d",
      "new_id": "7479f0b7c703606b0bd9a72b010831d1e1a26b13",
      "new_mode": 33188,
      "new_path": "gas/testsuite/gas/mips/r3900@mul.d"
    }
  ]
}
