)]}'
{
  "commit": "7dfecca0d25adb7874cbbe6f7211ad93a02e7ca9",
  "tree": "74378324dcc7770d5cc8ec249578d5356eb71fae",
  "parents": [
    "e4e53e546c76aa3ac386ad4816ee34069eddb54e"
  ],
  "author": {
    "name": "Pedro Alves",
    "email": "pedro@palves.net",
    "time": "Sat Aug 22 21:37:26 2020 +0100"
  },
  "committer": {
    "name": "Pedro Alves",
    "email": "pedro@palves.net",
    "time": "Sat Aug 22 21:37:26 2020 +0100"
  },
  "message": "Fix advance/until and multiple locations (PR gdb/26524)\n\nIf you do \"advance LINESPEC\", and LINESPEC expands to more than one\nlocation, GDB just errors out:\n\n   if (sals.size () !\u003d 1)\n     error (_(\"Couldn\u0027t get information on specified line.\"));\n\nFor example, advancing to a line in an inlined function, inlined three\ntimes:\n\n (gdb) b 21\n Breakpoint 1 at 0x55555555516f: advance.cc:21. (3 locations)\n (gdb) info breakpoints\n Num     Type           Disp Enb Address            What\n 1       breakpoint     keep y   \u003cMULTIPLE\u003e\n 1.1                         y   0x000055555555516f in inline_func at advance.cc:21\n 1.2                         y   0x000055555555517e in inline_func at advance.cc:21\n 1.3                         y   0x000055555555518d in inline_func at advance.cc:21\n (gdb) advance 21\n Couldn\u0027t get information on specified line.\n (gdb)\n\nSimilar issue with the \"until\" command, as it shares the\nimplementation with \"advance\".\n\nSince, as the comment in gdb.base/advance.exp says, \"advance \u003clocation\u003e\"\nis really just syntactic sugar for \"tbreak \u003clocation\u003e;continue\",\nfix this by making GDB insert a breakpoint at all the resolved\nlocations.\n\nA new testcase is included, which exercises both \"advance\" and\n\"until\", in two different cases expanding to multiple locations:\n\n  - inlined functions\n  - C++ overloads\n\nThis also exercises the inline frames issue fixed by the previous\npatch.\n\ngdb/ChangeLog:\n\n\tPR gdb/26524\n\t* breakpoint.c (until_break_fsm) \u003clocation_breakpoint,\n\tcaller_breakpoint\u003e: Delete fields.\n\t\u003cbreakpoints\u003e: New field.\n\t\u003cuntil_break_fsm\u003e: Adjust to save a breakpoint vector instead of\n\ttwo individual breakpoints.\n\t(until_break_fsm::should_stop): Loop over breakpoints in the\n\tbreakpoint vector.\n\t(until_break_fsm::clean_up): Adjust to clear the breakpoints\n\tvector.\n\t(until_break_command): Handle location expanding into multiple\n\tsals.\n\ngdb/testsuite/ChangeLog:\n\n\tPR gdb/26523\n\tPR gdb/26524\n\t* gdb.base/advance-until-multiple-locations.cc: New.\n\t* gdb.base/advance-until-multiple-locations.exp: New.",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "977599db1db40ceccf3814f38e8ef54e8c156a72",
      "old_mode": 33188,
      "old_path": "gdb/breakpoint.c",
      "new_id": "4f94a0acbacd1603751cce2b5ee487819eb47ec9",
      "new_mode": 33188,
      "new_path": "gdb/breakpoint.c"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "a90493805fa5617eaf874adea2fe9a317a47a788",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/advance-until-multiple-locations.cc"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "a6a1de6653de2e33f408ee093c2e2d0c84269afc",
      "new_mode": 33188,
      "new_path": "gdb/testsuite/gdb.base/advance-until-multiple-locations.exp"
    }
  ]
}
