commit 3bb711c44d92cbc5db9fa96a8113f13071ec4fbc
author dmalcolm <dmalcolm@138bc75d-0d04-0410-961f-82ee72b054a4> Sat Feb 16 16:17:17 2019 +0000
committer dmalcolm <dmalcolm@138bc75d-0d04-0410-961f-82ee72b054a4> Sat Feb 16 16:17:17 2019 +0000
tree d4ce7caa5c4014625f6fccf5e7a10714d8b7e302
parent 9ad48282b29f5d87459ca6016971008bbc14c505

Fix excess warnings from -Wtype-limits with location wrappers (PR c++/88680)

PR c++/88680 reports excess warnings from -Wtype-limits after the C++
FE's use of location wrappers was extended in r267272 for cases such as:

  const unsigned n = 8;
  static_assert (n >= 0 && n % 2 == 0, "");

t.C:3:18: warning: comparison of unsigned expression >= 0 is always true
  [-Wtype-limits]
    3 | static_assert (n >= 0 && n % 2 == 0, "");
      |                ~~^~~~

The root cause is that the location wrapper around "n" breaks the
suppression of the warning for the "if OP0 is a constant that is >= 0"
case.

This patch fixes it by calling fold_for_warn on OP0, extracting the
constant.

gcc/c-family/ChangeLog:
	PR c++/88680
	* c-common.c (shorten_compare): Call fold_for_warn on op0 when
	implementing -Wtype-limits.

gcc/testsuite/ChangeLog:
	PR c++/88680
	* g++.dg/wrappers/pr88680.C: New test.



git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@268961 138bc75d-0d04-0410-961f-82ee72b054a4