tree 018ac252eb1c43fe5247d98804d76d79aa003bfb
parent 974d59aec69b35bd4f7f8464a3bcfc55e849ed1f
author Jonathan Wakely <jwakely@redhat.com> 1748441958 +0100
committer Jonathan Wakely <redi@gcc.gnu.org> 1749564415 +0100
gpgsig -----BEGIN SSH SIGNATURE-----
 U1NIU0lHAAAAAQAAAhcAAAAHc3NoLXJzYQAAAAMBAAEAAAIBALuwf5VDJR4dRnHJAGYibx
 lckfAd3VDP8CyICvqpLfm6l9XP6KEjwxVrBbHgw7mDgjF3lr4t3bNQ1qP4ijXgqjZD6zJZ
 /kDrdBIHdxOa+pcSt8fQFh5rldeTSUjKSmXBp9z1Kek9rm1bcGo66eA1qQrouDeKwyOem9
 ou6CKYXMkI1oBrrWf+mvGBWSOO7pal3f+7z4tsJIQa9tsLogpZ2YfPzG1CTIXtQQrW1l8W
 h+iALiwQwmFhEBK5QabVXeoJsHH+ADfv612Dx51NgFK68gGO6CWNtAnL+z8YUFuStGJ0XD
 jxeMTu+6hLb3AjfNHR6L/o2egPez5+qSn82kVmVgd60YOfC1+qfpTalkunG1+yddsnJwtM
 aVIaAKDmmLgMQSLYvWNlrBfbvxuA2+rZNxfHL7LRQMEbqfnqcihkSs9V28K8wDITmwl2GP
 FrIzFrCOG9RcYZvBSMmXC3QTp8AHS4XGzFMnRq7SRhEZJ6E2eGOmcDhaanIV2OZB2EQNo9
 5Qsxcv1cCunVecivOh6mFrgSo5OnjdDfRePNP7OM1Jnfql7w0APXiV+MOSkAIjQBVJF6ls
 ZBQJT+ZVeAaYoU0Y6iVW/Jwf0pPytfo6I+PwoLxuqcjV06+Z2aL8o5d/+bh8bpwM5MTedn
 ZvZ//Wei+IRrD4Z08oWqSJVVBlIXJUC9AAAAA2dpdAAAAAAAAAAGc2hhNTEyAAACFAAAAA
 xyc2Etc2hhMi01MTIAAAIAUDj+lZad7xOUpjrLwGOwhrWt9CJa3Fkq4z+OsPrghH+IoO2k
 N/PERPRTGUBi4iu7dB0GuCsEwhhTw0LKWcBJhvi4sJSpzrNrKZlPKigJ79Ytim+w8uS/1n
 7X7bj5dgRVrIaFrMuISoJvfpM0ixThN+30OTG/43W0nSVT+9jcE9iJEn7cT5msI1oJaiQL
 gXBRV1eVGo2fMl4FTCVGMSdwx9kp5X76YBAxtHvk796ocUeNI3eREAshBY6drjF46U6TGQ
 5fvOSaYlVVwt6v0H6VCC8icvEDJGviQuiAdy2ooJp6+1h0vTYAUJWhXgO7VuF+yxkrYwLW
 Bxq6pw+VAsOSGfn5sj3tS1poMaXLHMXqvWC/P3ukVuQNz+0BYPtOsunzVxn+rZ9TcFFfX+
 T+nz04jeWirTN+Fdc/lMy+VAe9jAP5hWwRL9yZrMifIShmTsX9g9O5s5t6Ou77cQBH96KZ
 QTE6Wu8OsuV34BnGEdrMmnTaqN8puNG2cGTvohL5a4u+9sf9B1fw2YTQb66lvaSyR5XmH2
 GM0WTRJW1Q963DUoEheyDjr+LOsvZW+2wholGELLgFTolHHQs9eqhHQGW9lMY03otnzgpC
 o7LWulhw9bGywJUx550qsqyo/q18vhB5f5O2fHvRjMijzBFxjO0fDYXHqa+k2UISrSIdq2
 uA3Xo=
 -----END SSH SIGNATURE-----

libstdc++: Make system_clock::to_time_t always_inline [PR99832]

For some 32-bit targets Glibc supports changing the size of time_t to be
64 bits by defining _TIME_BITS=64. That causes an ABI change which
would affect std::chrono::system_clock::to_time_t. Because to_time_t is
not a function template, its mangled name does not depend on the return
type, so it has the same mangled name whether it returns a 32-bit time_t
or a 64-bit time_t. On targets where the size of time_t can be selected
at preprocessing time, that can cause ODR violations, e.g. the linker
selects a definition of to_time_t that returns a 32-bit value but a
caller expects 64-bit and so reads 32 bits of garbage from the stack.

This commit adds always_inline to to_time_t so that all callers inline
the conversion to time_t, and will do so using whatever type time_t
happens to be in that translation unit.

Existing objects compiled before this change will either have inlined
the function anyway (which is likely if compiled with any optimization
enabled) or will contain a COMDAT definition of the inline function and
so still be able to find it at link-time.

The attribute is also added to system_clock::from_time_t, because that's
an equally simple function and it seems reasonable for them to both be
always inlined.

libstdc++-v3/ChangeLog:

	PR libstdc++/99832
	* include/bits/chrono.h (system_clock::to_time_t): Add
	always_inline attribute to be agnostic to the underlying type of
	time_t.
	(system_clock::from_time_t): Add always_inline for consistency
	with to_time_t.
	* testsuite/20_util/system_clock/99832.cc: New test.

(cherry picked from commit d045eb13b0b42870a1f081895df3901112a358f0)