tree 79d3a5576878f91a4f881e3c6085adc773e7fa23
parent d6bbca7b78745915d98bb1324d79de6a1e6dc801
author Martin Jambor <mjambor@suse.cz> 1669137723 +0100
committer Martin Jambor <mjambor@suse.cz> 1669138124 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCgAdFiEE5elVTFt/d09Vsoczv2PBvD+kNUAFAmN9BswACgkQv2PBvD+k
 NUCqlhAAj7G4cJ/Oa7D4jsktNuAeVDvd5e2MEcWy8RdB2YEM6E1Z8YnAbLQSJTV/
 Seq5SVpPQ6AJNbzdq4+0eLFnQswG7kzUod7hBj9cy9rLbHQkmfGZBtqflcDg2FT1
 V05kl1BWs3uTLu2Gmqmyw91+SdDbNATCvDLXMYrLwFgAhEjEV0RS9wN+3M71rYLE
 C6RbL3VCL0Wr8PfECigsmV4EEngS2GNP9r70hGUu6GOZEqO8krJalZ5dKcx4zSG/
 xydcHbeVGvSXkk//d9rAxaATn/IpVf0W+g0Cs7JCBbvMQ3IeZUrqGPbBPwITvwDs
 7CHFptiOXz68zKgVCjuIX3i8JTVHelvUEfr3w9aHm2droLXvHltL/kiGltM0rT6E
 uvxAyX3OVyLpOghJ/psoAWJgCjQvR1qi3gG1TWxjv2xsR9tO6fH18uAD3lM+9z1a
 LEM4rjowBJepe0kPbyuDDsgl7yoBbR/A9L4/tyh7X63n46c7mk5zjIEaQjl+kJ1G
 kq44jES1N8jTj6m1CbdYMQjOhDVhJo8Rir44pWZKtpPvy7ks6pF6vq6bCGM13cSM
 QzSRzDh36h+CuuPA/6wN7yUgPQPr9fz3DgxlJIbxOu5bn21pIYlm+CaRTRu/eLYu
 hzEEFUqxRJAWNpGo84PNNzDO4Cn9X+s96CAxmSLCPzr72dYtI0U=
 =FSs1
 -----END PGP SIGNATURE-----

ipa-cp: Do not be too optimistic about self-recursive edges (PR 107661)

PR 107661 shows that function push_agg_values_for_index_from_edge
should not attempt to optimize self-recursive call graph edges when
called from cgraph_edge_brings_all_agg_vals_for_node.  Unlike when
being called from find_aggregate_values_for_callers_subset, we cannot
expect that any cloning for constants would lead to the edge leading
from a new clone to the same new clone, in this case it would only be
redirected to a new callee.

Fixed by adding a parameter to push_agg_values_from_edge whether being
optimistic about self-recursive edges is possible.

gcc/ChangeLog:

2022-11-22  Martin Jambor  <mjambor@suse.cz>

	PR ipa/107661
	* ipa-cp.cc (push_agg_values_from_edge): New parameter
	optimize_self_recursion, use it to decide whether to pass interim to
	the helper function.
	(find_aggregate_values_for_callers_subset): Pass true in the new
	parameter of push_agg_values_from_edge.
	(cgraph_edge_brings_all_agg_vals_for_node): Pass false in the new
	parameter of push_agg_values_from_edge.

gcc/testsuite/ChangeLog:

2022-11-22  Martin Jambor  <mjambor@suse.cz>

	PR ipa/107661
	* g++.dg/ipa/pr107661.C: New test.