commit 411c7e044fa99089d3030f2c61525c4d415f7b45
author Tom de Vries <tdevries@suse.de> Sun Aug 07 16:03:00 2022 +0200
committer Tom de Vries <tdevries@suse.de> Sun Aug 07 16:03:00 2022 +0200
tree 00a07d232628a0bed533e1d87dfc2ce7bdf15eb2
parent c7cd10637c40a72564bc813f3f16a4ba4b13d21b

[gdb/build] Fix build with gcc 4.8.5

When building with gcc 4.8.5, I run into:
...
user-regs.c:85:1: error: could not convert \
  ‘{0l, (& builtin_user_regs.gdb_user_regs::first)}’ from \
  ‘<brace-enclosed initializer list>’ to ‘gdb_user_regs’
 };
 ^
...

Fix this by removing the initialization and handling regs.last == nullptr in
append_user_reg.

Tested on x86_64-linux.

gdb/user-regs.c

diff --git a/gdb/user-regs.c b/gdb/user-regs.c
index 4bc4685..05bb04e 100644
--- a/gdb/user-regs.c
+++ b/gdb/user-regs.c
@@ -74,15 +74,15 @@
   reg->xread = xread;
   reg->baton = baton;
   reg->next = NULL;
+  if (regs->last == nullptr)
+    regs->last = &regs->first;
   (*regs->last) = reg;
   regs->last = &(*regs->last)->next;
 }
 
 /* An array of the builtin user registers.  */
 
-static struct gdb_user_regs builtin_user_regs = {
-  NULL, &builtin_user_regs.first
-};
+static struct gdb_user_regs builtin_user_regs;
 
 void
 user_reg_add_builtin (const char *name, user_reg_read_ftype *xread,