commit 12c00048d9f3598e57b98ec7723f7356bd255d04
author Andrew Pinski <quic_apinski@quicinc.com> Wed Aug 21 17:41:38 2024 -0700
committer Richard Biener <rguenth@gcc.gnu.org> Wed Sep 18 10:16:16 2024 +0200
tree 9829aa4976fc2f583e1cb9b943cbfca8bcd6f0b9
parent 8f8a7e1f1904e389e736c0265b4f515f3ce13659

fold: Fix `a * 1j` if a has side effects [PR116454]

The problem here was a missing save_expr around arg0 since
it is used twice, once in REALPART_EXPR and once in IMAGPART_EXPR.
Thia adds the save_expr and reformats the code slightly so it is a
little easier to understand.  It excludes the case when arg0 is
a COMPLEX_EXPR since in that case we'll end up with the distinct
real and imaginary parts.  This is important to retain early
optimization in some testcases.

Bootstapped and tested on x86_64-linux-gnu with no regressions.

	PR middle-end/116454

gcc/ChangeLog:

	* fold-const.cc (fold_binary_loc): Fix `a * +-1i`
	by wrapping arg0 with save_expr when it is not COMPLEX_EXPR.

gcc/testsuite/ChangeLog:

	* gcc.dg/torture/pr116454-1.c: New test.
	* gcc.dg/torture/pr116454-2.c: New test.

Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
Co-Authored-By: Richard Biener  <rguenther@suse.de>
(cherry picked from commit b07f8a301158e53717b8688cc8ea430b6f02574c)