commit 484fb60fdcb33703e32f1770cf2b406a4428a680
author Eric Botcazou <ebotcazou@adacore.com> Mon May 05 16:59:13 2025 +0200
committer Eric Botcazou <ebotcazou@adacore.com> Tue Jul 01 16:33:58 2025 +0200
tree e9fc158d755ecd011c4143ef05d8d93d927be333
parent 54b5f782727413885b89e8292ae60156ff50446c

ada: Fix wrong finalization of constrained array derived from unconstrained

The bug had been present for dynamically allocated objects since the first
rewrite of the finalization machinery more than a decade ago, and was then
propagated to statically declared objects by the recent rewrite.

gcc/ada/ChangeLog:

	* exp_util.adb (Finalize_Address): Do not go to the root type for
	array types.

gcc/ada/exp_util.adb

diff --git a/gcc/ada/exp_util.adb b/gcc/ada/exp_util.adb
index 1874420..2510b3f 100644
--- a/gcc/ada/exp_util.adb
+++ b/gcc/ada/exp_util.adb
@@ -6072,9 +6072,10 @@
       --  now known to be protected, the finalization routine is the one
       --  defined on the corresponding record of the ancestor (corresponding
       --  records do not automatically inherit operations, but maybe they
-      --  should???)
+      --  should???). This does not apply to array types, where every base
+      --  type has a finalization routine that depends on the first subtype.
 
-      if Is_Untagged_Derivation (Btyp) then
+      if Is_Untagged_Derivation (Btyp) and then not Is_Array_Type (Btyp) then
          if Is_Protected_Type (Btyp) then
             Utyp := Corresponding_Record_Type (Root_Type (Btyp));