commit 6bf473089f3c0c6ecf101f87f705618b1707fa82
author Eugene Rozenfeld <erozen@microsoft.com> Thu Sep 22 18:12:01 2022 -0700
committer Eugene Rozenfeld <erozen@microsoft.com> Tue Sep 27 16:46:42 2022 -0700
tree 1dbd38db0e1d892b18cdef2f6d3c3625c8645de3
parent 772d532e0ba1e4b22c2b7d576e14b34ee929c093

Fix profile count comparison.

The comparison was incorrect when the counts weren't PRECISE.
For example, crossmodule-indir-call-topn-1.c was failing
with AutoFDO: when count_sum is 0 with quality AFDO,
count_sum > profile_count::zero() evaluates to true. Taking that
branch then leads to an assert in the call to to_sreal().

Tested on x86_64-pc-linux-gnu.

gcc/ChangeLog:

	* ipa-cp.cc (good_cloning_opportunity_p): Fix profile count comparison.

gcc/ipa-cp.cc

diff --git a/gcc/ipa-cp.cc b/gcc/ipa-cp.cc
index 543a933..66bba71 100644
--- a/gcc/ipa-cp.cc
+++ b/gcc/ipa-cp.cc
@@ -3338,9 +3338,9 @@
 
   ipa_node_params *info = ipa_node_params_sum->get (node);
   int eval_threshold = opt_for_fn (node->decl, param_ipa_cp_eval_threshold);
-  if (count_sum > profile_count::zero ())
+  if (count_sum.nonzero_p ())
     {
-      gcc_assert (base_count > profile_count::zero ());
+      gcc_assert (base_count.nonzero_p ());
       sreal factor = count_sum.probability_in (base_count).to_sreal ();
       sreal evaluation = (time_benefit * factor) / size_cost;
       evaluation = incorporate_penalties (node, info, evaluation);